You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Circles are currently 20-side polygons. This PR increases that number to 100 for much better visual effect. It also fixes an inconsistency: previously, circle outlines were 30-side polygons, but filled circles had just 20 sides.
Before
After
Testing this on an example project revealed that the old version took around 3µs per circle in release mode, while the new one took 4µs. Given that the circle is five times more precise now, that seems like a good tradeoff.
It always will be a compromise, people do use draw_circle to draw a thousand of very little circles, and 5 would be a good enough number of vertices. And people will use draw_circles for full_screen circles, where even a 100 will be not enough.
For every use case, people can just call draw_poly and set whatever amount of sides they want. So I think it is just the question which use case for circles is more common and should be covered by draw_circle: many very small ones or fewer bigger ones. I don't know which one is more common though, so I see why you don't want to change this.
Maybe there is some better solution that calls into miniquad rendering directly without needing draw_poly and without speed losses?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Circles are currently 20-side polygons. This PR increases that number to 100 for much better visual effect. It also fixes an inconsistency: previously, circle outlines were 30-side polygons, but filled circles had just 20 sides.
Before
After
Testing this on an example project revealed that the old version took around 3µs per circle in release mode, while the new one took 4µs. Given that the circle is five times more precise now, that seems like a good tradeoff.
This supersedes #713.