added get_last_key_pressed()#954
Closed
lukasx999 wants to merge 1 commit intonot-fl3:masterfrom
lukasx999:dev
Closed
added get_last_key_pressed()#954lukasx999 wants to merge 1 commit intonot-fl3:masterfrom lukasx999:dev
lukasx999 wants to merge 1 commit intonot-fl3:masterfrom
lukasx999:dev
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think it would be useful to also get the last key that's being held down.
About the TODO's:
I suppose it's not possible to get the first item of a HashSet, as the hash function is randomly generated by default. (https://doc.rust-lang.org/std/collections/struct.HashSet.html)
To fix this, we could either use a consistent hash function, (which would possibly introduce vulnerabilities) or use a simple Vec (which will be slower).