Skip to content

fix the sticky key down #962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
not-fl3 merged 1 commit into from
May 4, 2025
Merged

fix the sticky key down #962

not-fl3 merged 1 commit into from
May 4, 2025

Conversation

@InnocentusLime
Copy link
Contributor

@InnocentusLime InnocentusLime commented May 4, 2025 •
edited
Loading

This PR:

  1. Closes is_key_down keep being true when window gets unfocused #547
  2. Fixes a potential issue for mouse buttons
  3. All active key_down issue key_released when the focus is lost
  4. All active touches are released too

This PR fixes it for all platforms for all platforms, where miniquad issues window_minimized_event.

However, not-fl3/miniquad#552 will make this fix work for Windows and make it behave better on WASM.

@InnocentusLime InnocentusLime force-pushed the fix-sticky-key-down branch from 32323c8 to 94f06cb Compare May 4, 2025 10:35
@InnocentusLime
Copy link
Contributor Author

InnocentusLime commented May 4, 2025

Also closes #357

@not-fl3 not-fl3 merged commit ae59b47 into not-fl3:master May 4, 2025
5 of 6 checks passed
@not-fl3
Copy link
Owner

not-fl3 commented May 4, 2025

Thanks for PR!

@InnocentusLime InnocentusLime deleted the fix-sticky-key-down branch November 5, 2025 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

is_key_down keep being true when window gets unfocused

2 participants

@InnocentusLime @not-fl3