Skip to content

remove references to Bridge2Kubernetes from contributing guide#2343

Merged
binbin-li merged 1 commit intonotaryproject:v1-devfrom
shahramk64:skalantari/remove-bridge2kubernetes-references
Aug 1, 2025
Merged

remove references to Bridge2Kubernetes from contributing guide#2343
binbin-li merged 1 commit intonotaryproject:v1-devfrom
shahramk64:skalantari/remove-bridge2kubernetes-references

Conversation

@shahramk64
Copy link
Contributor

Description

Bridge2Kubernetes is deprecated an not maintained anymore. Any references to it should be removed from the contributing guide

Which issue(s) does this PR resolve?

Fixes #2342

  • This change requires a documentation update

Testing and verification

Checklist

  • Does the affected code have corresponding tests?
  • Are the changes documented, not just with inline documentation, but also with conceptual documentation such as an overview of a new feature, or task-based documentation like a tutorial? Consider if this change should be announced on your project blog.
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have appropriate license header?

Post merge requirements

  • MAINTAINERS: manually trigger the "Publish Package" workflow after merging any PR that indicates Helm Chart Change

shizhMSFT
shizhMSFT previously approved these changes Jul 21, 2025
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jul 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (dev@493940f). Learn more about missing BASE report.

Additional details and impacted files
@@          Coverage Diff           @@
##             dev    #2343   +/-   ##
======================================
  Coverage       ?   73.33%           
======================================
  Files          ?      143           
  Lines          ?     9014           
  Branches       ?        0           
======================================
  Hits           ?     6610           
  Misses         ?     2030           
  Partials       ?      374           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@shahramk64 shahramk64 force-pushed the skalantari/remove-bridge2kubernetes-references branch from 7c63b4f to b9a4b8d Compare July 21, 2025 03:35
@binbin-li
Copy link
Contributor

@shahramk64 thanks for the fix, actually can you update PR to merge to v1-dev branch?

@shahramk64 shahramk64 force-pushed the skalantari/remove-bridge2kubernetes-references branch from b9a4b8d to e1afe67 Compare July 21, 2025 05:14
@shahramk64 shahramk64 changed the base branch from dev to v1-dev July 21, 2025 05:14
@shahramk64 shahramk64 force-pushed the skalantari/remove-bridge2kubernetes-references branch 2 times, most recently from 5bc4e44 to 3173628 Compare July 21, 2025 05:18
@shahramk64
Copy link
Contributor Author

shahramk64 commented Jul 21, 2025

@shahramk64 thanks for the fix, actually can you update PR to merge to v1-dev branch?

Sure
I rebased off v1-dev and pushed again, and changed the base branch to v1-dev. Let me know if it needs anything else.

Copy link
Contributor

@binbin-li binbin-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for update

@binbin-li
Copy link
Contributor

looks like the commit is not signed

@shahramk64 shahramk64 force-pushed the skalantari/remove-bridge2kubernetes-references branch 2 times, most recently from 41bf8fa to 2de66ba Compare July 31, 2025 11:07
Signed-off-by: Shahram Kalantari <shahramk@gmail.com>
@shahramk64 shahramk64 force-pushed the skalantari/remove-bridge2kubernetes-references branch from 2de66ba to 9d08f62 Compare August 1, 2025 01:16
@binbin-li binbin-li merged commit 340d73e into notaryproject:v1-dev Aug 1, 2025
1 check passed
RemindD pushed a commit to RemindD/ratify that referenced this pull request Sep 9, 2025
…yproject#2343)

Signed-off-by: Shahram Kalantari <shahramk@gmail.com>
Signed-off-by: Xingdong <xdlisjtu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants