Open
Conversation
…po-starter into feat/203-restyle-starter-components
…o-starter into feat/203-restyle-starter-components
…o-starter into feat/STAR-203-restyle-starter-components
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements a comprehensive redesign of the starter components to match the shadcn/ui design system, adds full dark mode support, introduces a new nested navigation system with mobile menu, and adds several new reusable Strapi components. The changes align the demo site with the design from notumstrapi.com.
Changes:
- Added shadcn/ui theme variables and dark mode support with proper color tokens and animations
- Implemented new nested navbar with desktop dropdown menus and mobile slide-in navigation supporting subcategories
- Introduced three new Strapi components: StrapiFeaturesList, StrapiStatistics, and StrapiCTABanner for enhanced content presentation
- Refactored existing components (Hero, AnimatedLogoRow) to use CKEditor rich text fields instead of plain text
- Removed deprecated StrapiHorizontalImages component and replaced functionality with StrapiFeaturesList
- Updated UI components (Button, Select, DropdownMenu, etc.) to use shadcn/ui styling patterns
- Changed CSS units from
emtoremthroughout the theme for consistency
Reviewed changes
Copilot reviewed 79 out of 83 changed files in this pull request and generated 35 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/design-system/src/theme.css | Added shadcn/ui color tokens for light/dark modes, changed units from em to rem, added accordion animations |
| packages/design-system/src/custom-styles.css | Added global dark mode styling for paragraph elements |
| apps/ui/src/styles/globals.css | Added dark mode custom variant, marquee animations, removed hardcoded background colors |
| apps/ui/src/components/ui/button.tsx | Updated button variants for shadcn/ui styling, adjusted sizes and hover states |
| apps/ui/src/components/ui/select.tsx | Updated placeholder styling syntax |
| apps/ui/src/components/ui/dropdown-menu.tsx | Added cursor-pointer, updated data attribute selectors |
| apps/ui/src/components/ui/navigation-menu.tsx | New component for desktop dropdown navigation menus |
| apps/ui/src/components/ui/accordion.tsx | Added cursor-pointer to trigger |
| apps/ui/src/components/page-builder/single-types/navbar/* | Complete navbar refactor with separate desktop/mobile components |
| apps/ui/src/components/page-builder/single-types/footer/StrapiFooter.tsx | Updated layout and added ThemeToggle |
| apps/ui/src/components/page-builder/components/sections/StrapiHero.tsx | Refactored to use CKEditor fields instead of plain text |
| apps/ui/src/components/page-builder/components/sections/StrapiFeaturesList.tsx | New component for displaying feature lists in various layouts |
| apps/ui/src/components/page-builder/components/sections/StrapiFigures.tsx | New component for displaying statistics/figures |
| apps/ui/src/components/page-builder/components/sections/StrapiCTABanner.tsx | New component for call-to-action banners with features |
| apps/ui/src/components/page-builder/components/sections/StrapiAnimatedLogoRow.tsx | Refactored animation logic and changed text field to CKEditor |
| apps/ui/src/components/page-builder/components/sections/StrapiHorizontalImages.tsx | Removed (replaced by StrapiFeaturesList) |
| apps/ui/src/components/elementary/AppLink.tsx | Added disableAnimations prop to control icon animations |
| apps/ui/src/components/elementary/Container.tsx | Updated max-width values |
| apps/ui/src/components/elementary/ThemeToggle.tsx | Added className prop for positioning |
| apps/ui/src/components/elementary/Breadcrumbs.tsx | Updated colors to use theme tokens |
| apps/ui/src/components/providers/ClientProviders.tsx | Removed forcedTheme="light" to enable dark mode |
| apps/ui/src/components/typography/config.ts | Added dark mode color variants |
| apps/ui/src/types/general.ts | Added PageBuilderComponentProps type |
| apps/ui/src/lib/strapi-api/content/server.ts | Updated navbar populate structure |
| apps/strapi/src/components/layout/navbar-item.json | New component schema for navbar items with conditional fields |
| apps/strapi/src/components/sections/* | Multiple new and updated component schemas |
| apps/strapi/src/components/shared/* | New shared component schemas |
| apps/strapi/src/api/navbar/content-types/navbar/schema.json | Breaking change: replaced links with navbarItems and primaryButtons |
| apps/strapi/src/api/page/content-types/page/schema.json | Removed horizontal-images, added new section types |
| apps/ui/package.json | Added @radix-ui/react-navigation-menu dependency |
| apps/ui/locales/*.json | Added "back" translation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
apps/ui/src/components/page-builder/single-types/navbar/MobileNavigation.tsx
Show resolved
Hide resolved
apps/ui/src/components/page-builder/components/sections/StrapiAnimatedLogoRow.tsx
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task Link
#203
Description
Fixed missing UI variables required by shadcn/ui components that previously caused them to break
Styled components to visually match the default shadcn/ui components from the official documentation
Restored missing default animations used by shadcn components
Fixed dark mode switching: Added missing light/dark mode values, Ensured components correctly handle both themes, Improved compatibility with values coming from Strapi CKEditor - only images from strapi can look strange in different theme
I also changed some EM values according to documentation as it was causing some UI inconsistencies
I introduced new components: StrapiFeatureList , StrapiStatistics and StrapiCTABanner
I have deleted some components as HorizontalImages which were duplicated
I changed current components to always receive a container, use ckEditor or have shared values across the repo
I also added shadCn NavigationMenu and introduced new nested Navbar with subcategories but also an option to use the NavbarItem as a link
I also added a mobile menu with subcategories component
-I filled in the website according to https://www.notumstrapi.com/ in czech and english and added some documentation pages in the footer and exported data as strapi.export.tar.gz
note: the error on the page is regarding S3 images
Screenshots/Videos
video:
https://drive.google.com/file/d/11Mk4dFgBUuU8U8lVjMoheCkQ5tyyLDy8/view?usp=sharing
Checklist - author
requires-env-varswhen PR requires environmental variablesready-for-reviewwhen PR is ready to be looked atready-to-mergewhen PR has a passing reviewneeds-revisionswhen PR has comments that block mergedo-not-reviewwhen PR is daft only and you don't want to get a reviewBefore merging
Checklist - reviewer