Add naming support extension to descriptor upgrade leaving current contract intact#479
Open
iainnash wants to merge 2 commits intonounsDAO:masterfrom
Open
Add naming support extension to descriptor upgrade leaving current contract intact#479iainnash wants to merge 2 commits intonounsDAO:masterfrom
iainnash wants to merge 2 commits intonounsDAO:masterfrom
Conversation
Merged
volkyeth
referenced
this pull request
in lilnouns/lilnouns-auction
May 2, 2025
expand asset library with `head-green-snake` for improved variety.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a metadata descriptor wrapper contract that adds in naming support.
It allows for naming any previously added components and also (if made the admin contract) the ability to proxy additions to the metadata and add names.
Names are returned using 1155 style string properties in the metadata json, largely accepted by most all marketplaces.
Migration plan:
Before deployment:
(or will relying on storage be more simple/cleaner to follow)