Skip to content

Add naming support extension to descriptor upgrade leaving current contract intact#479

Open
iainnash wants to merge 2 commits intonounsDAO:masterfrom
iainnash:add_naming_support_extension
Open

Add naming support extension to descriptor upgrade leaving current contract intact#479
iainnash wants to merge 2 commits intonounsDAO:masterfrom
iainnash:add_naming_support_extension

Conversation

@iainnash
Copy link

@iainnash iainnash commented Jun 6, 2022

This PR introduces a metadata descriptor wrapper contract that adds in naming support.

It allows for naming any previously added components and also (if made the admin contract) the ability to proxy additions to the metadata and add names.

Names are returned using 1155 style string properties in the metadata json, largely accepted by most all marketplaces.

Migration plan:

  1. deploy new rendering library
  2. deploy new descriptor pointing to previous descriptor
  3. make a request for the admin to be the DAO
  4. [or 3]: add in previous names to the contract
  5. propose a batch (1. set owner to DAO, set current descriptor owner to new contract, set nouns renderer to new contract, funds for devs)

Before deployment:

  1. code review
  2. better testing
  3. should previous names be included as a static call to save gas costs upon deploying
    (or will relying on storage be more simple/cleaner to follow)

@iainnash iainnash mentioned this pull request Jul 18, 2022
volkyeth referenced this pull request in lilnouns/lilnouns-auction May 2, 2025
expand asset library with `head-green-snake` for improved variety.
@volkyeth volkyeth moved this to Backlog in Nouns dev May 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

1 participant