Skip to content

feat: add missing assets to the nouns-assets#904

Open
nekofar wants to merge 6 commits intonounsDAO:masterfrom
nekofar:feature/update-nouns-assets
Open

feat: add missing assets to the nouns-assets#904
nekofar wants to merge 6 commits intonounsDAO:masterfrom
nekofar:feature/update-nouns-assets

Conversation

@nekofar
Copy link
Contributor

@nekofar nekofar commented Apr 29, 2025

hey @volkyeth; saw you grabbed this so i held off on pushing mine; but i’ve already done some work on #899 that might come in handy. let me know if you want me to merge it lol 😅

@nekofar nekofar force-pushed the feature/update-nouns-assets branch from 03e62eb to 4eed943 Compare April 29, 2025 16:43
nekofar added 6 commits April 29, 2025 19:45
expand color palette for increased design flexibility.
added new image asset to expand available design options.
add new body color `body-lilac` to enhance visual variety.
introduce 'head-sock' image for expanded customization options.
These `.gitkeep` files were removed to clean up unused directories.
This improves repository organization and reduces clutter.
update version to align with recent changes and improvements.
@nekofar nekofar force-pushed the feature/update-nouns-assets branch from 4eed943 to 67a5108 Compare April 29, 2025 16:45
Comment on lines +243 to +244
"f9fafb",
"e5e7eb"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where did those come from?

onchain data stops at d4cfc0. ref: https://assets.noundry.wtf/nouns/image-data.json

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those are generated by encode script if I’m not mistaken, I've added those but didn't verify with onchain data.

"encode": "ts-node scripts/encode.ts",

@volkyeth
Copy link
Member

I think we should replace the whole image-data.json with the one from Noundry

this one is out of sync with onchain since that prop patching the artwork, it seems. ref: volkyeth/noundry@ef2e0ae

(also added the accessory- prefix to body-bege, body-gray-scale-1, body-gray-scale-9, body-ice-cold on that one for consistency)

@nekofar
Copy link
Contributor Author

nekofar commented Apr 29, 2025

cool this script uses existing files in the repo to generate a json file. i’ve been tinkering on another script to auto-generate and update it from onchain data and bump the package but it’s still WIP lol 😅

@volkyeth
Copy link
Member

cool this script uses existing files in the repo to generate a json file. i’ve been tinkering on another script to auto-generate and update it from onchain data and bump the package but it’s still WIP lol 😅

https://github.com/volkyeth/noundry/blob/main/apps/assets/src/app/nouns/update/route.ts :D

needs work, tho
I was triggering it with Alchemy webhooks watching the Descriptor, and it triggered it multiple times when sock was executed. maybe it expects a specific status or a quicker response.
Also need to make it idempotent wrt adding trait names (offchain trait names are a mess)

@volkyeth volkyeth moved this to Backlog in Nouns dev May 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

2 participants