Add requested examples #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evilkermit
changed the title
jarrah42
reviewed
Sep 26, 2025
jarrah42
reviewed
Sep 26, 2025
examples/data_selector/view.py
Outdated
| # circumstances. | ||
| NeutronDataSelector( | ||
| v_model="data.selected_files", | ||
| base_paths=["/HFIR", "/SNS"], |
There was a problem hiding this comment.
I would specify something that you know will exist, such as $HOME and /tmp.
There was a problem hiding this comment.
wait... is this an example of DataSelector or NeutronDataSelector? You should have one of each.
Member
Author
There was a problem hiding this comment.
I'll create one just for the DataSelector and set some paths as you mentioned.
jarrah42
reviewed
Sep 26, 2025
README.md
Outdated
| 4. [Conditionally disabling elements](examples/conditional_disabling) | ||
| 5. [Changing Pydantic rules based on user input](examples/dynamic_pydantic_rules) | ||
| 6. [Complex Pydantic rules](examples/complex_pydantic_rules) | ||
| 7. [Using datafiles from the Analysis Cluster](examples/data_selector) |
There was a problem hiding this comment.
can we move this to a separate ORNL Only section?, ditto ONCat.
jarrah42
reviewed
Sep 26, 2025
README.md
Outdated
| 6. [Complex Pydantic rules](examples/complex_pydantic_rules) | ||
| 7. [Using datafiles from the Analysis Cluster](examples/data_selector) | ||
| 8. [Selecting datafiles from ONCat](examples/oncat) | ||
| 9. [Running an NDIP tool](examples/run_ndip_tool) |
jarrah42
reviewed
Sep 26, 2025
| with vuetify.VCard(classes="mx-auto my-4 pa-1", max_width=600): | ||
| with HBoxLayout(classes="mb-2", gap="0.5em", valign="center"): | ||
| InputField(v_model="data.input_path") | ||
| with vuetify.VBtn( |
Member
Author
|
@jarrah42 I've updated the PR. Created an ORNL-specific subdirectory for examples and added an example for the plain DataSelector. Let me know if you want to see any other changes! |
This was referenced Oct 2, 2025
Closed
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Adds the requested examples from https://code.ornl.gov/groups/ndip/-/epics/252.
Checklist
Documentation Updates
Additional Notes
Closes #7
Closes #8