Skip to content

Conversation

@evilkermit
Copy link
Member

Summary of Changes

I've got two changes here:

  1. I've updated nova-trame to v1.0.1 and updated the examples to work with it properly.
  2. There are now examples for multi-tab and dialog setups that remove the need for flushState calls.

Checklist

  • The PR has a clear and concise title
  • Code is self-documented and follows style guidelines.
  • Automated tests are written and pass successfully.
  • Regression tests (e.g. manually triggered system tests, manual GUI/tool tests, ...) are performed to make sure the PR does not break anything (when applicable)
  • Readme file is present and up-to-date.

Documentation Updates

Additional Notes

@evilkermit evilkermit self-assigned this Oct 21, 2025
@evilkermit evilkermit linked an issue Oct 21, 2025 that may be closed by this pull request
@evilkermit
Copy link
Member Author

@andrewfayres Adding you here as I think you're the only one who hasn't been involved in this repo yet. I'd suggest going through the whole repo at least once and seeing if there's any other examples you'd like to see or if there are general changes to the repo you'd like to see.

@andrewfayres
Copy link

Looking through the changes and it all looks good. I'll go through and test them all this afternoon when we're done with meetings.

Copy link

@andrewfayres andrewfayres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I ran all of the examples. Everything seems fine.

There are no other examples that come to mind while looking at this but I'm sure something will come up.

@evilkermit evilkermit merged commit 08c6c43 into main Oct 30, 2025
1 check passed
@evilkermit evilkermit deleted the 15-add-dialog-example branch October 30, 2025 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add dialog example

3 participants