Conversation
Contributor
Unit Test Results 1 files 152 suites 22s ⏱️ Results for commit c83cf16. |
valentunn
commented
Sep 25, 2025
| * this asset. Note that this can have different type depending on the type of | ||
| * the corresponding asset | ||
| */ | ||
| export type OnChainAssetId = string | number | 'Native'; |
Author
There was a problem hiding this comment.
Can someone confirm whether storing 'Native' for native in the db is fine in terms of backward compatibility?
Author
|
Drafted untill correctness is verified |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OnChainAssetand usingAssetIdmoreassetIdfrom call data decoder. We always useassetnowgetOnChainAssetIdwhich is a replacement forgetAssetIdwhich was mixing local and on-chain idsgetAssetByTypeExtrasNOTE: I have not tested this PR so someone should go through it