Skip to content

Fix .NET 10+ TFM detection by parsing major version correctly #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Fix .NET 10+ TFM detection by parsing major version correctly #306

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6ead57e
Initial plan
Copilot Nov 1, 2025
6edea95
Fix .NET 10+ TFM detection by properly parsing major version
Copilot Nov 1, 2025
19d2907
Simplify major version extraction logic per code review
Copilot Nov 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion Source/MSBuild.Sdk.Extras/Build/Inference.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,10 +49,16 @@
</Choose>

<!-- Map short name to long name. See earlier comment for example of how to work with identifiers that are not recognized here -->

<!-- Extract major version for 'net' identifier to differentiate .NET 5+ from .NET Framework -->
<PropertyGroup Condition="'$(_SdkShortFrameworkIdentifier)' == 'net' AND '$(_SdkShortFrameworkVersion)' != ''">
<_SdkShortFrameworkMajorVersion>$(_SdkShortFrameworkVersion.Split('.')[0])</_SdkShortFrameworkMajorVersion>
</PropertyGroup>

<PropertyGroup Condition=" ('$(TargetFrameworkIdentifier)' == '' OR '$(TargetFrameworkIdentifier)' == '_') AND '$(_SdkShortFrameworkIdentifier)' != ''">
<TargetFrameworkIdentifier Condition="'$(_SdkShortFrameworkIdentifier)' == 'net'">.NETFramework</TargetFrameworkIdentifier>
<TargetFrameworkIdentifier Condition="'$(_SdkShortFrameworkIdentifier)' == 'netstandard'">.NETStandard</TargetFrameworkIdentifier>
<TargetFrameworkIdentifier Condition="'$(_SdkShortFrameworkIdentifier)' == 'netcoreapp' OR ('$(_SdkShortFrameworkIdentifier)' == 'net' AND $(_SdkShortFrameworkVersion[0]) >= 5)">.NETCoreApp</TargetFrameworkIdentifier>
<TargetFrameworkIdentifier Condition="'$(_SdkShortFrameworkIdentifier)' == 'netcoreapp' OR ('$(_SdkShortFrameworkIdentifier)' == 'net' AND '$(_SdkShortFrameworkMajorVersion)' &gt;= '5')">.NETCoreApp</TargetFrameworkIdentifier>
<TargetFrameworkIdentifier Condition="'$(_SdkShortFrameworkIdentifier)' == 'portable'">.NETPortable</TargetFrameworkIdentifier>
<TargetFrameworkIdentifier Condition="'$(_SdkShortFrameworkIdentifier)' == 'netmf'">.NETMicroFramework</TargetFrameworkIdentifier>

Expand Down
Loading