[Do NOT MERGE] Clean up the subscribers concept page #888
Conversation
WalkthroughThe documentation for the "Subscribers" concept in Novu has been significantly condensed, with detailed sections about metadata, management, preferences, and personalization removed. The revised content now focuses on the core definition and purpose of subscribers, emphasizing their unique identification and role in workflow targeting and personalization. Changes
Possibly related PRs
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
✅ Deploy Preview for docs-novu ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (3)
content/docs/platform/concepts/subscribers.mdx (3)
7-8: Remove unusedTab/Tabsimport
TabandTabsare imported but never referenced in the document. This will trigger an “unused import” warning during the MDX build.-import { Tab, Tabs } from 'fumadocs-ui/components/tabs'; +
16-17: Tighten wording in the “subscriberId” sentenceThe phrase “can be updated or be duplicated” is slightly awkward. Dropping the second be reads more fluently.
-Unlike attributes such as email addresses or phone numbers, which can be updated or be duplicated across users, the `subscriberId` must remain stable and unique within your system. +Unlike attributes such as email addresses or phone numbers, which can be updated or duplicated across users, the `subscriberId` must remain stable and unique within your system.
27-27: Avoid triple repetition of “right” & add missing commaThe sentence repeats “right” three times and is missing a comma before regardless. Consider re-phrasing:
-At a high level, subscribers enable Novu to deliver the right message to the right person, in the right way regardless of how your system models users or customers. +At a high level, subscribers enable Novu to deliver the appropriate message to the right person, in the optimal way, regardless of how your system models users or customers.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
content/docs/platform/concepts/subscribers.mdx(1 hunks)
🧰 Additional context used
🪛 LanguageTool
content/docs/platform/concepts/subscribers.mdx
[style] ~27-~27: You have already used ‘right’ in nearby sentences. Consider using an alternative word to let your writing stand out and sound more polished.
Context: ...ovu to deliver the right message to the right person, in the right way regardless of ...
(REP_RIGHT)
[uncategorized] ~27-~27: Possible missing comma found.
Context: ...ssage to the right person, in the right way regardless of how your system models us...
(AI_HYDRA_LEO_MISSING_COMMA)
⏰ Context from checks skipped due to timeout of 90000ms (4)
- GitHub Check: Redirect rules - docs-novu
- GitHub Check: Header rules - docs-novu
- GitHub Check: Pages changed - docs-novu
- GitHub Check: Build and Lint
jainpawan21
changed the title
Summary by CodeRabbit