Skip to content

test(worker): Workflow skip logic e2e#10115

Draft
scopsy wants to merge 1 commit intonextfrom
cursor/workflow-skip-logic-e2e-7d22
Draft

test(worker): Workflow skip logic e2e#10115
scopsy wants to merge 1 commit intonextfrom
cursor/workflow-skip-logic-e2e-7d22

Conversation

@scopsy
Copy link
Contributor

@scopsy scopsy commented Feb 26, 2026

What changed? Why was the change needed?

Added a new E2E test for the v2 workflow API to validate the creation and retrieval of workflows with a payload schema and step-level skip conditions using JSONLogic. This ensures that complex workflow structures, including conditional step skipping, are correctly handled and persisted.

The test creates a workflow with a skipStep: string in its payload schema and two steps: an email step with a skipStep != "true" condition and an in-app step without a skip condition. It then verifies the workflow's successful creation and the proper storage of the skip logic.


Slack Thread

Open in Web Open in Cursor 

Co-authored-by: Dima Grossman <dima@grossman.io>
@cursor
Copy link
Contributor

cursor bot commented Feb 26, 2026

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

@netlify
Copy link

netlify bot commented Feb 26, 2026

Deploy Preview for dashboard-v2-novu-staging canceled.

Name Link
🔨 Latest commit 44b2863
🔍 Latest deploy log https://app.netlify.com/projects/dashboard-v2-novu-staging/deploys/69a099f5a6919d000828375b

@github-actions
Copy link
Contributor

github-actions bot commented Feb 26, 2026

Hey there and thank you for opening this pull request! 👋

We require pull request titles to follow specific formatting rules and it looks like your proposed title needs to be adjusted.

Your PR title is: test(worker): Workflow skip logic e2e

Requirements:

  1. Follow the Conventional Commits specification
  2. As a team member, include Linear ticket ID at the end: fixes TICKET-ID or include it in your branch name

Expected format: feat(scope): Add fancy new feature fixes NOV-123

Details:

PR title must end with 'fixes TICKET-ID' (e.g., 'fixes NOV-123') or include ticket ID in branch name

@scopsy scopsy changed the title Workflow skip logic e2e test(worker): Workflow skip logic e2e Feb 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants