Skip to content

feat(framework): export param types fixes NV-7261#10407

Merged
ChmaraX merged 1 commit intonextfrom
nv-7261-export-step-resolver-types-subscriber-contextresolved
Mar 19, 2026
Merged

feat(framework): export param types fixes NV-7261#10407
ChmaraX merged 1 commit intonextfrom
nv-7261-export-step-resolver-types-subscriber-contextresolved

Conversation

@ChmaraX
Copy link
Contributor

@ChmaraX ChmaraX commented Mar 19, 2026

What changed? Why was the change needed?

What changed

The framework now exports four commonly-used types from its public API: StepResolverContext, ContextResolved, Subscriber, and ExecuteInput. These types are essential for developers using the framework to properly type their step resolvers and workflow implementations. The StepResolverContext type was marked for export at its definition point, and all four types are now re-exported from both the main entry point and the step-resolver module for easier access.

Affected areas

@framework: Types are now exported from packages/framework/src/index.ts and packages/framework/src/step-resolver.ts, making them available to developers building workflows and step resolvers with the framework.

Testing

No tests were added, as type exports do not require runtime testing — TypeScript compilation validates that the types are correctly defined and exported.

Screenshots

Expand for optional sections

Related enterprise PR

Special notes for your reviewer

@linear
Copy link

linear bot commented Mar 19, 2026

@netlify
Copy link

netlify bot commented Mar 19, 2026

Deploy preview added

Name Link
🔨 Latest commit 617f55c
🔍 Latest deploy log https://app.netlify.com/projects/dashboard-v2-novu-staging/deploys/69bc1e3de2dd3f0008879cde
😎 Deploy Preview https://deploy-preview-10407.dashboard-v2.novu-staging.co
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions bot changed the title feat(framework): export param types feat(framework): export param types fixes NV-7261 Mar 19, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 19, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: e02e3926-f80e-40d7-addd-e300323ddd87

📥 Commits

Reviewing files that changed from the base of the PR and between 8bdf4bc and 617f55c.

📒 Files selected for processing (3)
  • packages/framework/src/index.ts
  • packages/framework/src/resources/step-resolver/step.ts
  • packages/framework/src/step-resolver.ts

📝 Walkthrough

Walkthrough

The public API is extended by re-exporting four types—StepResolverContext, ContextResolved, Subscriber, and ExecuteInput—across the framework's main entry point and secondary export module. The StepResolverContext type was simultaneously converted from internal to exported within its source file.

Changes

Cohort / File(s) Summary
Type Exports
packages/framework/src/index.ts, packages/framework/src/step-resolver.ts
Added re-exports of StepResolverContext, ContextResolved, and Subscriber types to public API surfaces. index.ts also re-exports ExecuteInput.
Internal Type Declaration
packages/framework/src/resources/step-resolver/step.ts
Converted StepResolverContext type alias from non-exported to exported, making it part of the public API.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title follows Conventional Commits format with valid type (feat) and scope (framework), uses lowercase imperative description, and includes Linear ticket reference (NV-7261) at the end.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ChmaraX ChmaraX merged commit 7d02277 into next Mar 19, 2026
38 checks passed
@ChmaraX ChmaraX deleted the nv-7261-export-step-resolver-types-subscriber-contextresolved branch March 19, 2026 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant