Skip to content

Extra validation when reading object properties#10

Open
hexploitable wants to merge 3 commits intonowsecure:mainfrom
hexploitable:label_validation
Open

Extra validation when reading object properties#10
hexploitable wants to merge 3 commits intonowsecure:mainfrom
hexploitable:label_validation

Conversation

@hexploitable
Copy link

I'm guessing if we can't get the handle from the view object, something is quite wrong, we may just want to return, but for now, I've added validation around the call.

@hexploitable hexploitable changed the title Extra validation of UINode object handles Extra validation when reading object properties Sep 29, 2020
@hexploitable
Copy link
Author

Bump :D

Copy link
Member

@oleavr oleavr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! (And sorry for the delay, totally missed this! 😅)

Looking at the code, the only explanation I can think of that this would happen is that either - placeholder or - string returns void. Was this observed in a UIView subclass?

@hexploitable
Copy link
Author

IIRC this was observed in a prod app that was doing some funky stuff with the UI which resulted in a crash. This was a stopgap fix, but I have zero idea which app it was. @mrmacete may know, but as far as timelines go, it was during the transition to QJS and running stresser loops.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants