Merged
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes flaky tests by improving test stability and consistency. The changes address timing-related test failures and inconsistent initial values that could cause intermittent test failures.
Key changes:
- Introduces an explicit initial value for
LastDragPositionto prevent reliance on default struct values - Extracts magic number (10) into a named constant
RandomTestRepeatCountfor better maintainability - Adjusts timing assertion threshold from 49ms to 17ms to reduce false failures
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| SpyOnDragHandler.cs | Adds explicit initial value for LastDragPosition to prevent test flakiness from default value comparisons |
| UguiSwipeOperatorTest.cs | Refactors repeat count to constant and updates assertions to use explicit initial value |
| UguiScrollWheelOperatorTest.cs | Replaces hardcoded repeat count with named constant |
| UguiDragAndDropOperatorTest.cs | Adds repeat attribute and updates assertion to use explicit initial value |
| UguiDoubleClickOperatorTest.cs | Loosens timing assertion threshold to reduce flaky failures |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Code Metrics Report
Details | | master (33ba08e) | #264 (8376475) | +/- |
|---------------------|------------------|----------------|--------|
| Coverage | 85.0% | 85.0% | 0.0% |
| Files | 67 | 67 | 0 |
| Lines | 2258 | 2258 | 0 |
| Covered | 1921 | 1921 | 0 |
+ | Code to Test Ratio | 1:1.3 | 1:1.3 | +0.0 |
| Code | 4162 | 4162 | 0 |
+ | Test | 5723 | 5728 | +5 |
- | Test Execution Time | 10m41s | 13m19s | +2m38s |Reported by octocov |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.