Skip to content

Fix to send drag event on last move#272

Merged
nowsprinting merged 1 commit intomasterfrom
fix/drag1frame
Oct 24, 2025
Merged

Fix to send drag event on last move#272
nowsprinting merged 1 commit intomasterfrom
fix/drag1frame

Conversation

@nowsprinting
Copy link
Copy Markdown
Owner

Problem

Do not send a drag event on the last move.
(It was leaving from while loop)

Fixes

Send a drag event even on the last move loop.

Copilot AI review requested due to automatic review settings October 24, 2025 21:49
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a bug where the drag event was not being sent during the final movement iteration. The code was exiting the loop via break before dispatching the final drag event, causing the last position update to be skipped.

Key Changes:

  • Replaced immediate loop exit with a flag-based approach to ensure the final drag event is dispatched

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions github-actions bot added the bug Something isn't working label Oct 24, 2025
@github-actions
Copy link
Copy Markdown

Code Metrics Report

master (180bd4e) #272 (6d54add) +/-
Coverage 85.0% 85.0% +0.0%
Code to Test Ratio 1:1.3 1:1.3 -0.1
Test Execution Time 9m43s 12m14s +2m31s
Details
  |                     | master (180bd4e) | #272 (6d54add) |  +/-   |
  |---------------------|------------------|----------------|--------|
+ | Coverage            |            85.0% |          85.0% |  +0.0% |
  |   Files             |               67 |             67 |      0 |
  |   Lines             |             2256 |           2258 |     +2 |
+ |   Covered           |             1919 |           1921 |     +2 |
- | Code to Test Ratio  |            1:1.3 |          1:1.3 |   -0.1 |
  |   Code              |             4161 |           4162 |     +1 |
  |   Test              |             5723 |           5723 |      0 |
- | Test Execution Time |            9m43s |         12m14s | +2m31s |

Code coverage of files in pull request scope (82.4% → 82.8%)

Files Coverage +/- Status
Runtime/Operators/Utils/PointerDragEventSimulator.cs 82.8% +0.3% modified

Reported by octocov

@nowsprinting nowsprinting merged commit 33ba08e into master Oct 24, 2025
15 checks passed
@nowsprinting nowsprinting deleted the fix/drag1frame branch October 24, 2025 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants