Fix to send drag event on last move#272
Merged
nowsprinting merged 1 commit intomasterfrom Oct 24, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where the drag event was not being sent during the final movement iteration. The code was exiting the loop via break before dispatching the final drag event, causing the last position update to be skipped.
Key Changes:
- Replaced immediate loop exit with a flag-based approach to ensure the final drag event is dispatched
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Code Metrics Report
Details | | master (180bd4e) | #272 (6d54add) | +/- |
|---------------------|------------------|----------------|--------|
+ | Coverage | 85.0% | 85.0% | +0.0% |
| Files | 67 | 67 | 0 |
| Lines | 2256 | 2258 | +2 |
+ | Covered | 1919 | 1921 | +2 |
- | Code to Test Ratio | 1:1.3 | 1:1.3 | -0.1 |
| Code | 4161 | 4162 | +1 |
| Test | 5723 | 5723 | 0 |
- | Test Execution Time | 9m43s | 12m14s | +2m31s |Code coverage of files in pull request scope (82.4% → 82.8%)
Reported by octocov |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Do not send a drag event on the last move.
(It was leaving from while loop)
Fixes
Send a drag event even on the last move loop.