Upgrade dependent test-helper package to v1.3.2 (Fix TakeScreenshotAsync performance)#286
Merged
nowsprinting merged 1 commit intomasterfrom Nov 20, 2025
Merged
Upgrade dependent test-helper package to v1.3.2 (Fix TakeScreenshotAsync performance)#286nowsprinting merged 1 commit intomasterfrom
nowsprinting merged 1 commit intomasterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the com.nowsprinting.test-helper dependency from version 1.3.1 to 1.3.2 to incorporate a performance fix for TakeScreenshotAsync. The package being updated is a core dependency used extensively throughout the codebase, particularly in the monkey testing implementation where screenshots are captured during test execution.
- Dependency version bump to incorporate upstream performance improvements
- The upgrade addresses performance issues in
TakeScreenshotAsync, which is actively used inMonkey.csfor capturing screenshots during UI testing
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Code Metrics Report
Details | | master (ab7f4e1) | #286 (82a29f3) | +/- |
|---------------------|------------------|----------------|------|
| Coverage | 88.9% | 88.9% | 0.0% |
| Files | 70 | 70 | 0 |
| Lines | 2557 | 2557 | 0 |
| Covered | 2275 | 2275 | 0 |
| Code to Test Ratio | 1:1.3 | 1:1.3 | 0.0 |
| Code | 4578 | 4578 | 0 |
| Test | 6103 | 6103 | 0 |
+ | Test Execution Time | 15m58s | 15m18s | -40s |Reported by octocov |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see: https://github.com/nowsprinting/test-helper/releases/tag/v1.3.2