Fix mapping of enums with duplicate labels#3743
Merged
roji merged 1 commit intonpgsql:mainfrom Feb 20, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes issue #3742 where mapping an enum with members that have the same value (duplicate labels) throws an ArgumentException. The solution allows enums with duplicate values by using the first label encountered, while ensuring that all duplicate values with [PgName] attributes have consistent mappings.
Changes:
- Modified
EnumDefinitionconstructor to handle duplicate enum values gracefully by keeping only the first label encountered - Added validation to throw
InvalidOperationExceptionwhen duplicate enum values have conflicting[PgName]attribute mappings - Added comprehensive unit tests covering four scenarios: duplicate values without attributes, with matching attributes, with different attributes, and with mixed attribute usage
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/EFCore.PG/Infrastructure/Internal/EnumDefinition.cs | Replaced simple ToDictionary with explicit loop that handles duplicate enum values and validates [PgName] consistency |
| test/EFCore.PG.Tests/Infrastructure/EnumDefinitionTest.cs | Added new test file with four test cases covering all duplicate enum value scenarios |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
roji
added a commit
that referenced
this pull request
Feb 20, 2026
Member
Author
|
Backported to 10.0.1 via 87ead6e |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3742