Skip to content

[draft] fix(aborist): reify should not create links to non-existent paths #8202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: latest
Choose a base branch
from
Draft

[draft] fix(aborist): reify should not create links to non-existent paths #8202

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions workspaces/arborist/lib/arborist/reify.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -807,8 +807,14 @@ module.exports = cls => class Reifier extends cls {
const dir = dirname(node.path)
const target = node.realpath
const rel = relative(dir, target)
await mkdir(dir, { recursive: true })
return symlink(rel, node.path, 'junction')
if (await lstat(target).catch(() => false)) {
await mkdir(dir, { recursive: true })
return symlink(rel, node.path, 'junction')
} else {
const er = new Error(`Target for link to ${node.name} (from ${[...node.edgesIn].map(e => e.from.name).join(', ')}) not found`)
er.code = 'ENOLINK'
throw er
}
}

// if the node is optional, then the failure of the promise is nonfatal
Expand Down