fix(ls): correctly show deduped dependencies

[milaninfy]

Attempt to fix npm ls output

Problem:

• deduped nodes are cloned when encountered using previously seen nodes set but they are not explored further when we are requesting npm ls dep-name if dep-name is a child of some deduped parent then whole tree would be shown till that parent but logically dep-name is still the child/grand-child of that.
• When deduped nodes are explored further it results in cycle when dep1 is ancestor of dep2 which again depends on dep1 creating a cycle when explored, also the algorithm used is BFS so it's hard to detect cycle.

Solution:

• Use DFS like approach with custom cycle detection checks.
  • keep track of how any node is discovered. so each node or parent node will have a list containing all the relevant visited nodes, we check if current node is in that list then it's a cycle and we don't need to explore this node.
• This solution attempts to explore cloned nodes of deduped nodes and use cached result so that it fixes the output and perform better. since those nodes are deduped and already explored we can use the result.

Progress:

• still some cases which might result in Infinite loop and need to discovered those.
• very slow and uses very large memory during run when ran on big repo, need to find out optimizations or better approach
• Fix/add the test cases
• Refactor

Test output

`npm ls child` - before and after

~/workarea/rep/repro $ npm ls child
[email protected] /Users/milaninfy/workarea/rep/repro
└─┬ [email protected]
  └─┬ [email protected]
    └─┬ [email protected]
      └── [email protected]

~/workarea/rep/repro $ lnpm ls child
[email protected] /Users/milaninfy/workarea/rep/repro
├─┬ [email protected]
│ └─┬ [email protected]
│   └─┬ [email protected]
│     └─┬ [email protected]
│       └── [email protected]
└─┬ [email protected]
  └─┬ [email protected] deduped
    └─┬ [email protected] deduped
      └── [email protected] deduped

fixes: #7917

[wraithgar]

This is displaying root nodes which are explicitly there cause of being a dependency as deduped which seems like an overstep.

deduped

The base npm ls should be much smaller than this PR makes it. For example with npm itself arborist has the mock registry fully listed in it instead of deduped.

this PR:

├─┬ @npmcli/[email protected] -> ./workspaces/arborist
│ ├── @isaacs/[email protected] deduped
│ ├── @npmcli/[email protected] deduped
│ ├── @npmcli/[email protected]
│ ├── @npmcli/[email protected]
│ ├── @npmcli/[email protected]
│ ├── @npmcli/[email protected]
│ ├─┬ @npmcli/[email protected] -> ./mock-registry
│ │ ├── @npmcli/[email protected] deduped -> ./workspaces/arborist
│ │ ├── @npmcli/[email protected] deduped
│ │ ├── @npmcli/[email protected]
│ │ ├── [email protected]
│ │ ├── [email protected]
│ │ ├── [email protected]
│ │ ├── [email protected]
│ │ └── [email protected]

npm:

├─┬ @npmcli/[email protected] -> ./workspaces/arborist
│ ├── @isaacs/[email protected] deduped
│ ├── @npmcli/[email protected] deduped
│ ├── @npmcli/[email protected] deduped
│ ├── @npmcli/[email protected]
│ ├── @npmcli/[email protected] deduped
│ ├── @npmcli/[email protected]
│ ├── @npmcli/[email protected] deduped -> ./mock-registry

Later, mock-registry (which is a root node) is also shown in both, but this PR dives back into arborist, and itself.

this PR:

├─┬ @npmcli/[email protected] deduped -> ./mock-registry
│ ├─┬ @npmcli/[email protected] -> ./workspaces/arborist
│ │ ├── @isaacs/[email protected] deduped
│ │ ├── @npmcli/[email protected] deduped
│ │ ├── @npmcli/[email protected]
│ │ ├── @npmcli/[email protected]
│ │ ├── @npmcli/[email protected]
│ │ ├── @npmcli/[email protected]
│ │ ├─┬ @npmcli/[email protected] -> ./mock-registry
│ │ │ ├── @npmcli/[email protected] deduped -> ./workspaces/arborist
│ │ │ ├── @npmcli/[email protected] deduped
│ │ │ ├── @npmcli/[email protected]
│ │ │ ├── [email protected]
│ │ │ ├── [email protected]
│ │ │ ├── [email protected]
│ │ │ ├── [email protected]
│ │ │ └── [email protected]

npm:

├─┬ @npmcli/[email protected] -> ./mock-registry
│ ├── @npmcli/[email protected] deduped -> ./workspaces/arborist
│ ├── @npmcli/[email protected] deduped
│ ├── @npmcli/[email protected] deduped
│ ├── [email protected]
│ ├── [email protected] deduped
│ ├── [email protected] deduped
│ ├── [email protected] deduped
│ └── [email protected] deduped

As it is I don't thing this fix is right. The base npm ls is mostly correct already and doesn't need to spool out like this. I do know there are cases where deduped nodes are displayed in the base npm ls but not later shown in their actual location, which would be a bug to fix. There is also the core bug listed when doing npm ls <dep>