Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion src/components/nav-drawer.js
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,19 @@ function NavDrawer() {

return (
<>
<Button aria-label="Menu" aria-expanded={open} onClick={() => setOpen(true)} sx={{ml: 3}}>
<Button
aria-label="Menu"
aria-expanded={open}
onClick={() => setOpen(true)}
sx={{
ml: 3,
'&:focus-visible': {
outline: '2px solid',
outlineColor: '-webkit-focus-ring-color',
outlineOffset: '1px',
},
}}
>
<ThreeBarsIcon />
</Button>
<LightTheme as={Drawer} isOpen={open} onDismiss={() => setOpen(false)}>
Expand Down
13 changes: 12 additions & 1 deletion src/components/search.js
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,18 @@ export const Mobile = ({
return (
<>
{!isMobileSearchOpen && (
<Button aria-label="Search" aria-expanded={isMobileSearchOpen} onClick={handleSearchToggle}>
<Button
aria-label="Search"
aria-expanded={isMobileSearchOpen}
onClick={handleSearchToggle}
sx={{
'&:focus-visible': {
outline: '2px solid',
outlineColor: '-webkit-focus-ring-color',
outlineOffset: '1px',
},
}}
>
<SearchIcon />
</Button>
)}
Expand Down
5 changes: 5 additions & 0 deletions src/components/table-of-contents.js
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,11 @@ export const Mobile = withTableOfContents(({items}) => {
borderBottomWidth: open ? 1 : 0,
borderBottomLeftRadius: open ? 0 : 2,
borderBottomRightRadius: open ? 0 : 2,
'&:focus-visible': {
outline: '2px solid',
outlineColor: '-webkit-focus-ring-color',
outlineOffset: '1px',
},
}}
leadingIcon={open ? ChevronDownIcon : ChevronRightIcon}
>
Expand Down
12 changes: 11 additions & 1 deletion src/components/variant-select.js
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
if (locationChange.change && getNav.didVariantChange(locationChange.previous, locationChange.current)) {
setOpen(false)
}
}, [locationChange.change, locationChange.current, locationChange.previous])

Check warning on line 48 in src/components/variant-select.js

View workflow job for this annotation

GitHub Actions / Lint

React Hook React.useEffect has a missing dependency: 'locationChange'. Either include it or remove the dependency array. Mutable values like 'locationChange.current' aren't valid dependencies because mutating them doesn't re-render the component

return (
<>
Expand All @@ -53,7 +53,17 @@
Select CLI Version:
</Box>
<ActionMenu anchorRef={anchorRef} open={open} onOpenChange={setOpen}>
<ActionMenu.Button aria-describedby={labelId} sx={{width: ['100%', null, 'auto']}}>
<ActionMenu.Button
aria-describedby={labelId}
sx={{
width: ['100%', null, 'auto'],
'&:focus-visible': {
outline: '2px solid',
outlineColor: '-webkit-focus-ring-color',
outlineOffset: '1px',
},
}}
>
{title}
</ActionMenu.Button>
<StyledOverlay width="auto" onEscape={() => setOpen(false)}>
Expand Down
2 changes: 1 addition & 1 deletion src/mdx/code.js
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ const ClipboardCopy = ({value, ...props}) => {
'&:focus-visible': {
outline: '2px solid',
outlineColor: '-webkit-focus-ring-color',
outlineOffset: '2px',
outlineOffset: '1px',
},
}}
>
Expand Down
Loading