Skip to content

[Fix Accessibility] Remove redundant role attribute from sidebar navigation list #1726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 30, 2025
Merged

[Fix Accessibility] Remove redundant role attribute from sidebar navigation list #1726

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
24a27e6
Remove redundant role attribute from sidebar navigation list
jpg619 Sep 25, 2025
0aca5cd
fix: adjust font size of InlineCode component to improve readability
jpg619 Sep 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/sidebar.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ const Sidebar = () => (
borderColor: 'border.subtle',
}}
>
<Box sx={{display: 'flex', flexDirection: 'column'}} role="list">
<Box sx={{display: 'flex', flexDirection: 'column'}}>
<NavItems />
</Box>
</Box>
Expand Down
2 changes: 1 addition & 1 deletion src/mdx/code.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ const ClipboardCopy = ({value, ...props}) => {
export const InlineCode = styled.code`
padding: 0.2em 0.4em;
font-family: ${themeGet('fonts.mono')};
font-size: 85%;
font-size: 80%;
background-color: ${themeGet('colors.neutral.muted')};
border-radius: ${themeGet('radii.2')};
`
Expand Down
Loading