-
Notifications
You must be signed in to change notification settings - Fork 3.4k
[Fix Accessibility]: Enhance accessibility by adding ARIA attributes to table of content #1730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+15
−4
Merged
Changes from 3 commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
d823495
feat: enhance accessibility by adding ARIA attributes to table of con…
jpg619 114304e
Revert "feat: enhance accessibility by adding ARIA attributes to tabl…
jpg619 b98d6f4
fix: add tabIndex to VariantItem for improved accessibility
jpg619 cb7345e
Revert "fix: add tabIndex to VariantItem for improved accessibility"
jpg619 d06a57d
fix: add tabIndex to VariantItem for improved accessibility
jpg619 4fdf5cf
Revert "fix: add tabIndex to VariantItem for improved accessibility"
jpg619 fbe09ce
fix: add tabIndex to VariantItem for improved accessibility
jpg619 c28a14d
Revert "fix: add tabIndex to VariantItem for improved accessibility"
jpg619 2447450
fix: remove tabindex from VariantItem after component renders
jpg619 37392ef
fix: simplify dependency array in VariantMenu useEffect
jpg619 101d84a
Revert "fix: simplify dependency array in VariantMenu useEffect"
jpg619 e0ea583
Revert "fix: remove tabindex from VariantItem after component renders"
jpg619 3f1b461
test commit
jpg619 0e11919
fix: simplify dependency array in VariantMenu useEffect
jpg619 65699af
Revert "test commit"
jpg619 642ed13
Revert "fix: simplify dependency array in VariantMenu useEffect"
jpg619 7c01211
Reapply "test commit"
jpg619 5829d6b
Revert "Reapply "test commit""
jpg619 0dca946
test commit
jpg619 591d55b
fix: add tabIndex to VariantItem for accessibility
jpg619 7067965
Revert "fix: add tabIndex to VariantItem for accessibility"
jpg619 d933bae
Revert "test commit"
jpg619 581915e
fix: add aria-labelledby attribute to SearchResults for accessibility
jpg619 62d4446
fix: add aria-posinset and aria-setsize attributes to SearchResults f…
jpg619 0e60f29
fix: update aria-label in SearchResults for improved accessibility
jpg619 e5e0042
fix: add data-has-description attribute to SearchResults for improved…
jpg619 74335e4
fix: add aria-label to SearchResults items for improved accessibility
jpg619 cc5fce7
fix: add aria-label to NavList.Item for improved accessibility
jpg619 aa50708
fix: update aria-label in TableOfContentsItems for improved accessibi…
jpg619 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.