Skip to content
This repository was archived by the owner on Aug 11, 2021. It is now read-only.

using clone because JSON.parse(JSON.stringify(...)) errors when given undefined #124

Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/publish.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ var assert = require('assert')
var fixer = require('normalize-package-data').fixer
var concat = require('concat-stream')
var ssri = require('ssri')
var clone = require('clone')

function escaped (name) {
return name.replace('/', '%2f')
Expand Down Expand Up @@ -75,7 +76,7 @@ function putFirst (registry, data, tarbuffer, access, auth, cb) {

if (!auth.token) {
root.maintainers = [{ name: auth.username, email: auth.email }]
data.maintainers = JSON.parse(JSON.stringify(root.maintainers))
data.maintainers = clone(root.maintainers)
}

root.versions[ data.version ] = data
Expand Down Expand Up @@ -173,8 +174,7 @@ function putNext (registry, newVersion, root, current, auth, cb) {
current[i] = root[i]
}
}
var maint = JSON.parse(JSON.stringify(root.maintainers))
root.versions[newVersion].maintainers = maint
root.versions[newVersion].maintainers = clone(root.maintainers)

var uri = url.resolve(registry, escaped(root.name))
var options = {
Expand Down
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
"index.js"
],
"dependencies": {
"clone": "^1.0.2",
"concat-stream": "^1.5.2",
"graceful-fs": "^4.1.6",
"normalize-package-data": "~1.0.1 || ^2.0.0",
Expand Down
3 changes: 2 additions & 1 deletion test/publish.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ var ssri = require('ssri')
var server = require('./lib/server.js')
var common = require('./lib/common.js')
var client = common.freshClient()
var clone = require('clone')

function nop () {}

Expand Down Expand Up @@ -145,7 +146,7 @@ test('publish call contract', function (t) {
)

t.test('malformed semver in publish', function (t) {
var metadata = JSON.parse(JSON.stringify(METADATA))
var metadata = clone(METADATA)
metadata.version = '%!@#$'
var params = {
metadata: metadata,
Expand Down