Skip to content

feat: filters items out of the release process that aren't for backports#553

Merged
owlstronaut merged 1 commit intomainfrom
backport-george-jetson
Mar 19, 2026
Merged

feat: filters items out of the release process that aren't for backports#553
owlstronaut merged 1 commit intomainfrom
backport-george-jetson

Conversation

@owlstronaut
Copy link
Copy Markdown
Contributor

@owlstronaut owlstronaut commented Mar 18, 2026

This pull request adds automated backport detection and filtering logic to the release process, ensuring that steps not relevant for backports are excluded from the checklist. It also introduces new tests and fixtures to verify this functionality.

@owlstronaut owlstronaut requested a review from a team as a code owner March 18, 2026 22:38
return false
}

if (isBackport && item.includes('<!-- NOT FOR BACKPORT -->')) {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only part that gives me pause. There is no way I'm gonna remember this comment in the source markdown is how the filter works.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair point — I liked the HTML comment approach since it keeps the checklist clean for the common (non-backport) case, but I agree discoverability matters here too. Happy to switch it to match the > NOT FOR PRERELEASE pattern if you think that's the way to go.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah sorry this is one of those "complaints without a solution". In the absence of a better idea we can ship this. I just know I get so lost every time I have to update that markdown file in the first place. Maybe discoverability of that should be something we can work on.

@owlstronaut owlstronaut merged commit 6bc2bc0 into main Mar 19, 2026
18 checks passed
@owlstronaut owlstronaut deleted the backport-george-jetson branch March 19, 2026 16:29
@github-actions github-actions bot mentioned this pull request Mar 19, 2026
owlstronaut pushed a commit that referenced this pull request Mar 19, 2026
🤖 I have created a release *beep* *boop*
---


##
[4.30.0](v4.29.0...v4.30.0)
(2026-03-19)
### Features
*
[`6bc2bc0`](6bc2bc0)
[#553](#553) filters items out
of the release process that aren't for backports (#553) (@owlstronaut)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants