update "process_frame" function to process 2DS data correctly#5
update "process_frame" function to process 2DS data correctly#5huangynj wants to merge 8 commits intonrc-cnrc:mainfrom
Conversation
|
@huangynj thank you for submitting this fix! It's a busy week this week for us at NRC but I'll go through the code changes and get back to you hopefully sometime next week. Thanks again! |
|
Actually, one request for you @huangynj if you have the time. Would you be able to create a new branch on your end, rebased from main, add the changes to there instead? This way I can clone the branch and play around with it. As it currently is, I have to first merge the changes with main before I can actually run the code. I can also do this on my end but it will be messier as I will have to copy portions of the code manually. I can create the branch first and you can push there also, if it make life easier. |
|
Hi @kennybala97, I have created a new branch: https://github.com/huangynj/NRC-SPIFpy/tree/2DS_HVPS_fix |
… improve code readability
Dmt pip cip fix
Hi @kennybala97,
I have updated the "process_frame" function to process 2DS data correctly based on the method I proposed in
#4 (comment)
I tested it using 1-min data and it works fine.
Yongjie