NF: Adds a PearsonRegressor model, so we can score Pearson connectomes.#6
Merged
NF: Adds a PearsonRegressor model, so we can score Pearson connectomes.#6
Conversation
Member
Author
|
This now passes the sklearn estimator checks locally on my laptop, but might need a bit more thorough checking perhaps with data simulated to produce specific coefficients. For example, make sure that all coefficients are identical when all columns of X are identical, make sure the prediction has the same variance as the input y and so on. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Still need to make this pass the sklearn tests.