app: Add CoAP support to nRF Cloud AT commands by juhaylinen · Pull Request #174 · nrfconnect/ncs-serial-modem

juhaylinen · 2026-02-09T14:39:55Z

Remove support for nRF Cloud MQTT protocol and use more lightweight CoAP connectivity.

Use CONFIG_SM_NRF_CLOUD_LOCATION to enable location support, since CONFIG_NRF_CLOUD_LOCATION depends on NRF_CLOUD_MQTT and cannot be enabled when using NRF_CLOUD_COAP.

Jira: SM-235

trantanen · 2026-03-05T10:20:13Z

app/src/sm_at_gnss.c

 {
 	int err;
 	struct nrf_modem_gnss_agnss_data_frame req;
+	static char agnss_rest_data_buf[NRF_CLOUD_AGNSS_MAX_DATA_SIZE];


This is 4kB buffer. This is a bit more general question on how we should deal with these. We use quite a lot of RAM for a feature that some/most hosts don't use at all.

app/prj.conf

app/src/sm_at_gnss.c

trantanen · 2026-03-05T15:15:04Z

app/src/sm_at_nrfcloud.c

+		.wifi_info = nrfcloud_wifi_pos ? &nrfcloud_wifi_data : NULL};

-	if (err) {
+	err = nrf_cloud_coap_location_get(&request, &result);


This is synchronous operation. Can this be a problem? nrf_cloud_location_request was asynchronous, right?
I guess this discussion is valid for all nrf_cloud_coap operations.

Yeah, nrf_cloud_coap operations are synchronous.

trantanen · 2026-03-05T15:18:28Z

app/src/sm_at_nrfcloud.c

+		LOG_ERR("Failed to allocate memory for message copy");
+		return -ENOMEM;
+	}
+	memcpy(msg_copy, message, len);


Would be nice to avoid this copy. Is it just for the NULL termination?

Yes, it's just for the NULL terminator.

I think we can avoid the copy by using direct call to nrf_cloud_coap_post()

app/src/sm_util.c

trantanen · 2026-03-05T15:25:10Z

app/Kconfig

 	default y
 	select EXPERIMENTAL

+config SM_NRF_CLOUD_LOCATION


I'd like to put this on by default if CONFIG_SM_NRF_CLOUD is on but that wouldn't be backwards compatible. As it's not such a big deal, I guess we'll just leve if OFF by default and enable in prj.conf as done earlier for CONFIG_NRF_CLOUD_LOCATION.

Add help text for this though as it's not clear what parts of nRF Cloud location functionality this means. I.e., is it cell and wifi positioning or A-GNSS or P-GPS. Some or all of them.

Added help text

trantanen · 2026-03-05T15:35:39Z

doc/app/sm_configuration.rst

+CONFIG_SM_NRF_CLOUD_LOCATION - Send GNSS location to nRF Cloud
+   This option enables automatic sending of GNSS location data to nRF Cloud when a fix is acquired.


Isn't this about cell and wifi positioning. Sending of GNSS location to cloud is controlled by run-time <send_location> parameter in AT#XNRFCLOUD

doc/app/at_nrfcloud.rst

divipillai · 2026-03-09T13:08:06Z

doc/app/sm_configuration.rst

+.. _CONFIG_SM_NRF_CLOUD_LOCATION:
+
+CONFIG_SM_NRF_CLOUD_LOCATION - nRF Cloud Location support
+   This option enables the nRF Cloud Location service for cloud-assisted geolocation.


Suggested change

This option enables the nRF Cloud Location service for cloud-assisted geolocation.

This option enables the `nRF Cloud Location Services <nRF Cloud Location Services documentation_>`_ for cloud-assisted geolocation.

nRF Cloud Location Services documentation - Could link to this page - https://docs.nordicsemi.com/bundle/nrf-cloud/page/LocationServices/LSOverview.html

divipillai · 2026-03-09T13:10:34Z

doc/app/at_nrfcloud.rst


   * The device must be connected to nRF Cloud using :ref:`#XNRFCLOUD <SM_AT_NRFCLOUD>`.
-   * The ``CONFIG_NRF_CLOUD_LOCATION`` Kconfig option must be enabled.
+   * The ``CONFIG_SM_NRF_CLOUD_LOCATION`` Kconfig option must be enabled.


Suggested change

* The ``CONFIG_SM_NRF_CLOUD_LOCATION`` Kconfig option must be enabled.

* The :ref:`CONFIG_SM_NRF_CLOUD_LOCATION <CONFIG_SM_NRF_CLOUD_LOCATION>` Kconfig option must be enabled.

divipillai · 2026-03-09T13:11:15Z

doc/migration_notes.rst

  * Functions and other symbols in the code have been renamed accordingly making automatic patching to likely fail.

 * Changed the default AT command terminator from ``\r\n`` (``CONFIG_SM_CR_LF_TERMINATION`` and ``CONFIG_SM_AT_CLIENT_CR_LF_TERMINATION``) to ``\r`` (``CONFIG_SM_CR_TERMINATION`` and ``CONFIG_SM_AT_CLIENT_CR_TERMINATION``).
+* Changed the nRF Cloud Location Kconfig option from ``CONFIG_NRF_CLOUD_LOCATION`` to |SM| specific ``CONFIG_SM_NRF_CLOUD_LOCATION``.


Suggested change

* Changed the nRF Cloud Location Kconfig option from ``CONFIG_NRF_CLOUD_LOCATION`` to |SM| specific ``CONFIG_SM_NRF_CLOUD_LOCATION``.

* Changed the nRF Cloud Location Kconfig option from ``CONFIG_NRF_CLOUD_LOCATION`` to |SM|-specific :ref:`CONFIG_SM_NRF_CLOUD_LOCATION <CONFIG_SM_NRF_CLOUD_LOCATION>`.

divipillai · 2026-03-09T13:13:34Z

doc/migration_notes.rst


 * Changed the default AT command terminator from ``\r\n`` (``CONFIG_SM_CR_LF_TERMINATION`` and ``CONFIG_SM_AT_CLIENT_CR_LF_TERMINATION``) to ``\r`` (``CONFIG_SM_CR_TERMINATION`` and ``CONFIG_SM_AT_CLIENT_CR_TERMINATION``).
+* Changed the nRF Cloud Location Kconfig option from ``CONFIG_NRF_CLOUD_LOCATION`` to |SM| specific ``CONFIG_SM_NRF_CLOUD_LOCATION``.
+  This option is now used to enable the nRF Cloud Location service for cloud-assisted geolocation, which supports A-GNSS, P-GPS, and Wi-Fi positioning.


Suggested change

This option is now used to enable the nRF Cloud Location service for cloud-assisted geolocation, which supports A-GNSS, P-GPS, and Wi-Fi positioning.

You can now use this option to enable the `nRF Cloud Location Services <nRF Cloud Location Services documentation_>`_ for cloud-assisted geolocation, which supports A-GNSS, P-GPS, and Wi-Fi positioning.

Add overlay to enable CoAP connectivity for nRF Cloud AT commands. Use CONFIG_SM_NRF_CLOUD_LOCATION to enable location support, since CONFIG_NRF_CLOUD_LOCATION depends on NRF_CLOUD_MQTT and cannot be enabled when using NRF_CLOUD_COAP. Jira: SM-235 Signed-off-by: Juha Ylinen <juha.ylinen@nordicsemi.no>

Use more lightweight CoAP protocol instead of MQTT. Signed-off-by: Juha Ylinen <juha.ylinen@nordicsemi.no>

juhaylinen requested a review from trantanen February 9, 2026 14:40

juhaylinen force-pushed the nrfcloud_coap branch from 89fa7ae to 661f320 Compare February 10, 2026 07:12

juhaylinen requested a review from MarkusLassila February 10, 2026 07:47

juhaylinen force-pushed the nrfcloud_coap branch from 661f320 to a6609d2 Compare February 17, 2026 09:23

juhaylinen force-pushed the nrfcloud_coap branch 3 times, most recently from 2c4cd7a to c61d096 Compare March 3, 2026 11:53

juhaylinen marked this pull request as ready for review March 3, 2026 12:55

juhaylinen force-pushed the nrfcloud_coap branch from c61d096 to 138ba28 Compare March 4, 2026 14:17

trantanen reviewed Mar 5, 2026

View reviewed changes

juhaylinen force-pushed the nrfcloud_coap branch 2 times, most recently from 8a15a37 to 99cbbe1 Compare March 6, 2026 13:54

juhaylinen requested review from SeppoTakalo and divipillai March 9, 2026 07:03

divipillai reviewed Mar 9, 2026

View reviewed changes

juhaylinen added 2 commits March 10, 2026 10:30

app: Remove support for nRF Cloud MQTT

ebf0f5c

Use more lightweight CoAP protocol instead of MQTT. Signed-off-by: Juha Ylinen <juha.ylinen@nordicsemi.no>

juhaylinen force-pushed the nrfcloud_coap branch from 99cbbe1 to ebf0f5c Compare March 10, 2026 09:00

		CONFIG_SM_NRF_CLOUD_LOCATION - Send GNSS location to nRF Cloud
		This option enables automatic sending of GNSS location data to nRF Cloud when a fix is acquired.

	This option enables the nRF Cloud Location service for cloud-assisted geolocation.
	This option enables the `nRF Cloud Location Services <nRF Cloud Location Services documentation_>`_ for cloud-assisted geolocation.

	* The ``CONFIG_SM_NRF_CLOUD_LOCATION`` Kconfig option must be enabled.
	* The :ref:`CONFIG_SM_NRF_CLOUD_LOCATION <CONFIG_SM_NRF_CLOUD_LOCATION>` Kconfig option must be enabled.

	* Changed the nRF Cloud Location Kconfig option from ``CONFIG_NRF_CLOUD_LOCATION`` to \|SM\| specific ``CONFIG_SM_NRF_CLOUD_LOCATION``.
	* Changed the nRF Cloud Location Kconfig option from ``CONFIG_NRF_CLOUD_LOCATION`` to \|SM\|-specific :ref:`CONFIG_SM_NRF_CLOUD_LOCATION <CONFIG_SM_NRF_CLOUD_LOCATION>`.

	This option is now used to enable the nRF Cloud Location service for cloud-assisted geolocation, which supports A-GNSS, P-GPS, and Wi-Fi positioning.
	You can now use this option to enable the `nRF Cloud Location Services <nRF Cloud Location Services documentation_>`_ for cloud-assisted geolocation, which supports A-GNSS, P-GPS, and Wi-Fi positioning.

Conversation

juhaylinen commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

juhaylinen commented Feb 9, 2026 •

edited

Loading