app: sms: More robust handling of concat SMS receiving#203
Draft
trantanen wants to merge 1 commit intonrfconnect:mainfrom
Draft
app: sms: More robust handling of concat SMS receiving#203trantanen wants to merge 1 commit intonrfconnect:mainfrom
trantanen wants to merge 1 commit intonrfconnect:mainfrom
Conversation
Fixes receiving of concatenated SMS messages in mixed order with normal short messages. Two concatenated message receiving in mixed order is still blocked as it's not important use case now. Dynamic memory is allocated to concatenated SMS messages. Earlier limit of 3 messages is now made to 10. This could have been unlimited but a limit is for security reasons. Jira: SM-36 Signed-off-by: Tommi Rantanen <tommi.rantanen@nordicsemi.no>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes receiving of concatenated SMS messages in mixed order with normal short messages.
Two concatenated message receiving in mixed order is still blocked as it's not important use case now.
Dynamic memory is allocated to concatenated SMS messages. Earlier limit of 3 messages is now made to 10.
This could have been unlimited but a limit is for security reasons.
Jira: SM-36