[nrf noup] boot: zephyr: Disable self RWX #491
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalek-no
force-pushed
the
mb-self-lock
branch
3 times, most recently
from
918b809 to
64f45fd
Compare
michalek-no
force-pushed
the
mb-self-lock
branch
from
64f45fd to
460752d
Compare
Disables read write and execute on mcuboots NVM at the end of execution. Signed-off-by: Mateusz Michalek <[email protected]>
michalek-no
force-pushed
the
mb-self-lock
branch
from
460752d to
a25c7c4
Compare
|
de-nordic
reviewed
Aug 13, 2025
| @@ -472,6 +472,13 @@ config MCUBOOT_CLEANUP_RAM | |||
| help | |||
| Sets contents of memory to 0 before jumping to application. | |||
|
|
|||
| config MCUBOOT_DISABLE_SELF_RWX | |||
There was a problem hiding this comment.
Suggested change
| config MCUBOOT_DISABLE_SELF_RWX | |
| config NCS_MCUBOOT_DISABLE_SELF_RWX |
There was a problem hiding this comment.
We are trying to not conflict noups with anything that may come from upstream.
| @@ -163,6 +182,84 @@ struct arm_vector_table { | |||
| uint32_t reset; | |||
| }; | |||
|
|
|||
| static void __ramfunc jump_in(uint32_t reset) | |||
There was a problem hiding this comment.
Can we have better name for this?
There was a problem hiding this comment.
Yes, however this is the hardest part. Any suggestions?
There was a problem hiding this comment.
Have you seen names I have invented?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disables read write and execute on mcuboots NVM
at the end of execution.