Skip to content

Fix board file styling and fixed partition compatible #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 10, 2025
Merged

Fix board file styling and fixed partition compatible #144

merged 5 commits into from
Jun 10, 2025

Conversation

nordicjm
Copy link
Contributor

No description provided.

nordicjm added 4 commits May 28, 2025 07:48
@nordicjm
boards: nordic: Fix devicetree styling
d74f941 
Adds line gaps where they should be

Signed-off-by: Jamie McCrae <[email protected]>
@nordicjm
boards: nordic: Fix abuse of fixed partition compatible
0157ffe 
RAM is not a fixed partition

Signed-off-by: Jamie McCrae <[email protected]>
@nordicjm
boards: nordic: Fix invalid use of Kconfig
1a7a2d8 
Fixes wrongly using Kconfigs

Signed-off-by: Jamie McCrae <[email protected]>
@nordicjm
board: nordic: Add MCUboot ROM start offset
7c22911 
Adds offsets when MCUboot is enabled

Signed-off-by: Jamie McCrae <[email protected]>
@nordicjm nordicjm requested a review from lemrey as a code owner May 28, 2025 12:11
MirkoCovizzi
MirkoCovizzi reviewed May 28, 2025
View reviewed changes
Copy link
Contributor

@MirkoCovizzi MirkoCovizzi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is using fixed-partition wrong for RAM when we separate the memory in partitions, e.g. for SoftDevice? I would like to understand the reason for the change.

@nordicjm
Copy link
Contributor Author

nordicjm commented May 28, 2025 •
edited
Loading

Is using fixed-partition wrong for RAM when we separate the memory in partitions, e.g. for SoftDevice? I would like to understand the reason for the change.

yes, fixed-partition is for flash devices and goes into the flash map, it is wrong to use this binding with RAM. From the devicetree binding:

description: |
  Fixed partitions of a flash (or other non-volatile storage) memory.

@nordicjm
boards: nordic: Add retention using GPREGRET1 for boot mode
e1bfb48 
Enables GPREGRET1 and assigns it as a retention device for use
with boot mode selection

Signed-off-by: Jamie McCrae <[email protected]>
eivindj-nordic
eivindj-nordic reviewed May 29, 2025
View reviewed changes
boards/nordic/bm_nrf54l10_template/cpuapp_common.dtsi Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally we would like to use the devicetree as little as possible. Though, I guess there is no good way to do this without?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correct, this is used by MCUboot

anhmolt
anhmolt reviewed Jun 2, 2025
View reviewed changes
boards/nordic/bm_nrf54l15dk/bm_nrf54l15dk_nrf54l15_cpuapp_common.dtsi Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw you fixed the start address of the gpregret registers in zephyr upstream. Do we need some patch until this has trickled down? Or do we expect it to be available downstream soon?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nrfconnect/sdk-zephyr#2920

@nordicjm
Copy link
Contributor Author

nordicjm commented Jun 9, 2025

@lemrey please review

@lemrey lemrey merged commit 0210b39 into nrfconnect:main Jun 10, 2025
6 checks passed
@nordicjm nordicjm deleted the fixnrf54l branch August 15, 2025 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anhmolt anhmolt anhmolt left review comments

@lemrey lemrey lemrey approved these changes

@MirkoCovizzi MirkoCovizzi MirkoCovizzi approved these changes

@eivindj-nordic eivindj-nordic eivindj-nordic approved these changes

@nvlsianpu nvlsianpu Awaiting requested review from nvlsianpu

@michalek-no michalek-no Awaiting requested review from michalek-no

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@nordicjm @lemrey @MirkoCovizzi @eivindj-nordic @anhmolt