Skip to content

boards: dts: Update memory layout for nRF54L #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 15, 2025
Merged

boards: dts: Update memory layout for nRF54L #200

merged 1 commit into from
Aug 15, 2025

Conversation

Vge0rge
Copy link
Contributor

@Vge0rge Vge0rge commented Jul 9, 2025 •
edited by eivindj-nordic
Loading 

Adjust the memory layout of all the nRF54l variants
to take into account that the top 64 bytes of RAM
are reserved for the KMU. Here 128 bytes of memory are
reserved for future proofness.

Depends on: nrfconnect/sdk-nrf#23870

@Vge0rge Vge0rge requested review from a team as code owners July 9, 2025 14:06
@eivindj-nordic eivindj-nordic requested a review from a team July 10, 2025 06:46
@eivindj-nordic eivindj-nordic added the DNM Do not merge label Jul 10, 2025
@eivindj-nordic
Copy link
Contributor

Adding DNM as samples are not booting as they should.

hermabe
hermabe requested changes Jul 31, 2025
View reviewed changes
Copy link
Member

@hermabe hermabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RAM conflict

@eivindj-nordic eivindj-nordic added this to the v0.9.0 milestone Aug 6, 2025
@Vge0rge Vge0rge requested a review from a team as a code owner August 8, 2025 11:21
@Vge0rge Vge0rge requested a review from hermabe August 8, 2025 11:22
hermabe
hermabe approved these changes Aug 8, 2025
View reviewed changes
Copy link
Member

@hermabe hermabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK from SoftDevice

@Vge0rge Vge0rge force-pushed the rearrange_memory branch 4 times, most recently from 1d3c20b to e2dbe8a Compare August 11, 2025 12:01
MirkoCovizzi
MirkoCovizzi reviewed Aug 11, 2025
View reviewed changes
boards/nordic/bm_nrf54l15dk/bm_nrf54l15dk_nrf54l05_cpuapp_common.dtsi Outdated
@@ -12,6 +12,24 @@
zephyr,flash-controller = &rram_controller;
zephyr,boot-mode = &boot_mode0;
};

soc {
reserved-memory {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, I adjusted it in all 3 files

eivindj-nordic
eivindj-nordic reviewed Aug 11, 2025
View reviewed changes
boards/nordic/bm_nrf54l15dk/bm_nrf54l15dk_nrf54l15_cpuapp_s115_softdevice_mcuboot.dts Outdated
@@ -48,12 +48,12 @@

boot_partition: partition@0 {
label = "boot";
reg = <0x00000000 DT_SIZE_K(36)>;
reg = <0x00000000 DT_SIZE_K(40)>;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this increased?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michalek-no Can you comment on this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually reverted it now since it was conflicting and I was not sure how to solve. And at the same time I could build mcuboot with the current sizes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michalek-no Can you comment on this?

That's temporarily needed to be able to build it without LTO.

@Vge0rge Vge0rge force-pushed the rearrange_memory branch 2 times, most recently from e7f0361 to 9e04df4 Compare August 12, 2025 12:54
@Vge0rge Vge0rge requested a review from a team as a code owner August 12, 2025 12:54
@NordicBuilder
Copy link

NordicBuilder commented Aug 12, 2025 •
edited
Loading

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff

✅ All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@Vge0rge
Copy link
Contributor Author

Vge0rge commented Aug 12, 2025

FYI: I saw that this PR stopped working because of some recent commits in this repo. So I reverted the commits just so this PR can work again, this is not an optimal solution and probably not what it will be merged in the end. But until there is a better solution I reverted them here.

nordicjm
nordicjm requested changes Aug 12, 2025
View reviewed changes
Copy link
Contributor

@nordicjm nordicjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the reverts here are not acceptable to be reverted

@michalek-no
Copy link
Contributor

the reverts here are not acceptable to be reverted

weird thing:
https://github.com/michalek-no/sdk-nrf-bm/tree/rearrange_mem
this without reverts yields the same mcuboot/zephyr/.config but doesn't work

nordicjm
nordicjm reviewed Aug 15, 2025
View reviewed changes
@Vge0rge
boards: bm_nrf54l: Adjust memory layout
1f32023 
Adjust the memory layout of all the nRF54l variants
to take into account that the top 64 bytes of RAM
are reserved for the KMU. Here 128 bytes of memory are
reserved for future proofness.

Signed-off-by: Georgios Vasilakis <[email protected]>
@Vge0rge Vge0rge requested a review from nordicjm August 15, 2025 10:52
@eivindj-nordic eivindj-nordic merged commit f65c869 into nrfconnect:main Aug 15, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MirkoCovizzi MirkoCovizzi MirkoCovizzi left review comments

@hermabe hermabe hermabe approved these changes

@seko-nordic seko-nordic seko-nordic left review comments

@eivindj-nordic eivindj-nordic eivindj-nordic left review comments

@nordicjm nordicjm nordicjm approved these changes

@anhmolt anhmolt anhmolt approved these changes

@michalek-no michalek-no michalek-no approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.8.0
Development

Successfully merging this pull request may close these issues.
9 participants
@Vge0rge @eivindj-nordic @NordicBuilder @michalek-no @MirkoCovizzi @hermabe @nordicjm @seko-nordic @anhmolt