manifest: update internal repository revision #278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following west manifest projects have changed revision in this Pull Request:
⛔ DNM label due to: 1 project with PR revision Note: This message is automatically posted and updated by the Manifest GitHub Action. |
nordicjm
requested changes
Aug 20, 2025
Comment on lines
15
to
23
| config HAS_SOFTDEVICE_S115 | ||
| bool | ||
| depends on BOARD_BM_NRF54L15DK_NRF54L05_CPUAPP_S115_SOFTDEVICE || \ | ||
| BOARD_BM_NRF54L15DK_NRF54L05_CPUAPP_S115_SOFTDEVICE_MCUBOOT || \ | ||
| BOARD_BM_NRF54L15DK_NRF54L10_CPUAPP_S115_SOFTDEVICE || \ | ||
| BOARD_BM_NRF54L15DK_NRF54L10_CPUAPP_S115_SOFTDEVICE_MCUBOOT || \ | ||
| BOARD_BM_NRF54L15DK_NRF54L15_CPUAPP_S115_SOFTDEVICE || \ | ||
| BOARD_BM_NRF54L15DK_NRF54L15_CPUAPP_S115_SOFTDEVICE_MCUBOOT | ||
| default y |
There was a problem hiding this comment.
this does not belong here
There was a problem hiding this comment.
I think this can be removed in total. Should be enough to depend on the SoC.
| @@ -10,7 +10,7 @@ zephyr_library_sources( | |||
| irq_connect.c | |||
| ) | |||
|
|
|||
| if (CONFIG_SOFTDEVICE_S115) | |||
| if (CONFIG_SOFTDEVICE AND CONFIG_SOC_SERIES_NRF54LX) | |||
There was a problem hiding this comment.
no space between bracket and if in cmake
eivindj-nordic
force-pushed
the
internal_update
branch
from
71bc942 to
e4bc017
Compare
|
You can find the documentation preview for this PR here. |
Update nrf-bm-internal revision. Some changes required to Kconfig etc. Signed-off-by: Eivind Jølsgard <[email protected]>
eivindj-nordic
force-pushed
the
internal_update
branch
from
e4bc017 to
5a56781
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update nrf-bm-internal revision.
Some changes required to Kconfig etc.