samples: peripheral: add PWM sample #346
Conversation
|
You can find the documentation preview for this PR here. |
eivindj-nordic
force-pushed
the
pwm_sample
branch
from
9692fbe to
86d019f
Compare
eivindj-nordic
force-pushed
the
pwm_sample
branch
from
86d019f to
3c56a65
Compare
github-actions
bot
added
changelog-entry-required
eivindj-nordic
force-pushed
the
pwm_sample
branch
from
3c56a65 to
60eb383
Compare
samples/peripherals/pwm/README.rst
Outdated
| Overview | ||
| ******** | ||
|
|
||
| The sample initializes a PWM instance and use that to iluminate LED1 and LED3 on the device. |
There was a problem hiding this comment.
| The sample initializes a PWM instance and use that to iluminate LED1 and LED3 on the device. | |
| The sample initializes a PWM instance that blinks LED1 and LED3 on the device. |
samples/peripherals/pwm/README.rst
Outdated
|
|
||
| .. note:: | ||
|
|
||
| PWM signal can be exposed on GPIO pin only within same domain. |
There was a problem hiding this comment.
| PWM signal can be exposed on GPIO pin only within same domain. | |
| The PWM signal can be exposed only on GPIO pins that belong to the same domain as the target pins. |
A suggestion, but maybe it can be improved further.
samples/peripherals/pwm/README.rst
Outdated
|
|
||
| PWM signal can be exposed on GPIO pin only within same domain. | ||
| For nRF54L-series there is only one domain which contains both PWM and GPIO: PWM20/21/22 and GPIO Port P1. | ||
| Only LEDs connected to P1 can work with PWM, in this case LED1 and LED3. |
There was a problem hiding this comment.
I think it could be a good idea to insert here a link to the datasheet or some reference where the user can check this information.
There was a problem hiding this comment.
I don't think this is required here. It can make sense when we only have the nRF54L15 DK, though for other boards it might be different. Then this will also require a rewrite.
|
|
||
| config PWM_IRQ_PRIO | ||
| int "PWM IRQ priority" | ||
| default 5 |
There was a problem hiding this comment.
Should this mirror other similar Kconfigs of other peripheral libraries? Taking into account SoftDevice and such.
There was a problem hiding this comment.
It already mirrors how it is done for LPUARTE and UARTE.
Add sample to show the use of PWM. Signed-off-by: Eivind Jølsgard <[email protected]>
eivindj-nordic
force-pushed
the
pwm_sample
branch
from
60eb383 to
37fc765
Compare
Add sample to show the use of PWM.