-
Notifications
You must be signed in to change notification settings - Fork 21
sdh: simplifications and improvements #388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
2b9ee6a
1e893a9
28089a4
a767014
c200b77
4229682
307d8e5
c8c251d
ab5e941
822882b
565a9cf
093c9f1
9431dee
a0bd9e2
39652c2
e07d39b
381bff5
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
.. _lib_nrf_sdh: | ||
|
||
SoftDevice handler | ||
################## | ||
|
||
The SoftDevice handler is a library that handles SoftDevice initialization tasks, and pulls and dispatches the SoftDevice events to registered components. | ||
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -27,7 +27,26 @@ No changes since the latest nRF Connect SDK Bare Metal release. | |||||
SoftDevice Handler | ||||||
================== | ||||||
|
||||||
No changes since the latest nRF Connect SDK Bare Metal release. | ||||||
* Added: | ||||||
|
||||||
* The :option:`NRF_SDH_SOC_RAND_SEED` Kconfig option to control whether to automatically respond to SoftDevice random seed requests. | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
* Priority levels for SoftDevice event observers: HIGHEST, HIGH, USER, USER_LOW, LOWEST. | ||||||
* The :c:func:`nrf_sdh_ble_evt_tostr` function to stringify a BLE event. | ||||||
* The :c:func:`nrf_sdh_soc_evt_tostr` function to stringify a SoC event. | ||||||
|
||||||
* Changed: | ||||||
|
||||||
* The return type of the :c:type:`nrf_sdh_state_evt_handler_t` event handler to ``int``. | ||||||
|
||||||
* Removed: | ||||||
|
||||||
* The ``NRF_SDH_BLE`` Kconfig option. | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think it should be like this:
Suggested change
|
||||||
* The ``NRF_SDH_STATE_REQ_OBSERVER`` macro and relative data types. | ||||||
Register a state event observer and return non-zero to ``NRF_SDH_STATE_EVT_ENABLE_PREPARE`` | ||||||
or ``NRF_SDH_STATE_EVT_DISABLE_PREPARE`` to abort state changes instead. | ||||||
* The ``nrf_sdh_ble_app_ram_start_get`` function. | ||||||
* The ``nrf_sdh_request_continue`` function. | ||||||
* The ``nrf_sdh_is_enabled`` function. | ||||||
|
||||||
Boards | ||||||
====== | ||||||
|
Original file line number | Diff line number | Diff line change | ||||||||
---|---|---|---|---|---|---|---|---|---|---|
|
@@ -75,7 +75,7 @@ extern "C" { | |||||||||
.data_pool = &CONCAT(_name, _heap), \ | ||||||||||
}; \ | ||||||||||
NRF_SDH_BLE_OBSERVER(CONCAT(_name, _obs), ble_gq_on_ble_evt, (void *)&_name, \ | ||||||||||
CONFIG_BLE_GQ_OBSERVER_PRIO) | ||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should remove There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks, done |
||||||||||
HIGH) | ||||||||||
Comment on lines
77
to
+78
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'll leave the formatting as it is, we can do that work separately. |
||||||||||
|
||||||||||
/** | ||||||||||
* @brief Helper macro for initializing connection handle array. Used in @ref BLE_GQ_CUSTOM_DEF. | ||||||||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be good with more skin on the bone, though I guess that can be added later as well.