Skip to content

Conversation

nordicjm
Copy link
Contributor

@nordicjm nordicjm commented Oct 3, 2025

Adds the compliance checks that are being used in sdk-nrf

@nordicjm nordicjm requested review from a team as code owners October 3, 2025 08:12
@NordicBuilder
Copy link

NordicBuilder commented Oct 3, 2025

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff
nrf nrfconnect/sdk-nrf@b1f505f nrfconnect/sdk-nrf#24872 nrfconnect/sdk-nrf#24872/files

DNM label due to: 1 project with PR revision

Note: This message is automatically posted and updated by the Manifest GitHub Action.

Copy link

github-actions bot commented Oct 3, 2025

You can find the documentation preview for this PR here.


- name: check-warns
working-directory: nrf-bm
working-directory: ncs/nrf
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be nrf-bm?

@github-actions github-actions bot removed the manifest label Oct 3, 2025
@NordicBuilder NordicBuilder removed manifest-nrf DNM Do not merge labels Oct 3, 2025
@nordicjm nordicjm force-pushed the compliancechecks branch 3 times, most recently from 2838e73 to 8fdf0e4 Compare October 3, 2025 12:03
@nordicjm
Copy link
Contributor Author

nordicjm commented Oct 3, 2025

@rghaddab @eivindj-nordic @MirkoCovizzi Please see and fix Kconfig compliance issues on https://github.com/nrfconnect/sdk-nrf-bm/actions/runs/18221678088?pr=410

@eivindj-nordic
Copy link
Contributor

@rghaddab @eivindj-nordic @MirkoCovizzi Please see and fix Kconfig compliance issues on https://github.com/nrfconnect/sdk-nrf-bm/actions/runs/18221678088?pr=410

Opened #413.

Copy link
Contributor

@MirkoCovizzi MirkoCovizzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me when compared to the NCS one.

Copy link
Contributor

@eivindj-nordic eivindj-nordic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nordicjm Please rebase, or were you planning to add further updates to this PR?

Removes enable text from a Kconfig option

Signed-off-by: Jamie McCrae <[email protected]>
Includes changes in compliance CI checks

Signed-off-by: Jamie McCrae <[email protected]>
Adds files that are generated as part of compliance checks to
the .gitignore list

Signed-off-by: Jamie McCrae <[email protected]>
Adds the compliance checks that are being used in sdk-nrf

Signed-off-by: Jamie McCrae <[email protected]>
test DNR

Signed-off-by: Jamie McCrae <[email protected]>
@nordicjm nordicjm requested a review from a team as a code owner October 7, 2025 14:11
@NordicBuilder NordicBuilder added the DNM Do not merge label Oct 7, 2025
@eivindj-nordic
Copy link
Contributor

@nordicjm I assume there are PRs to memfault etc. that fixes the compliance issues seen here now. I cannot see anything related to this repo.

@nordicjm
Copy link
Contributor Author

nordicjm commented Oct 8, 2025

@nordicjm I assume there are PRs to memfault etc. that fixes the compliance issues seen here now. I cannot see anything related to this repo.

The various groups are responsible for fixing them, they have been asked to fix them, and those tasks are listed under NCSDK-35791

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants