-
Notifications
You must be signed in to change notification settings - Fork 19
workflow: compliance: Use additional compliance checks #410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
nordicjm
commented
Oct 3, 2025
The following west manifest projects have changed revision in this Pull Request:
⛔ DNM label due to: 1 project with PR revision Note: This message is automatically posted and updated by the Manifest GitHub Action. |
You can find the documentation preview for this PR here. |
.github/workflows/compliance.yml
Outdated
|
||
- name: check-warns | ||
working-directory: nrf-bm | ||
working-directory: ncs/nrf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be nrf-bm?
1dc5073
to
fe8d839
Compare
2838e73
to
8fdf0e4
Compare
@rghaddab @eivindj-nordic @MirkoCovizzi Please see and fix Kconfig compliance issues on https://github.com/nrfconnect/sdk-nrf-bm/actions/runs/18221678088?pr=410 |
Opened #413. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me when compared to the NCS one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nordicjm Please rebase, or were you planning to add further updates to this PR?
Removes enable text from a Kconfig option Signed-off-by: Jamie McCrae <[email protected]>
Includes changes in compliance CI checks Signed-off-by: Jamie McCrae <[email protected]>
Adds files that are generated as part of compliance checks to the .gitignore list Signed-off-by: Jamie McCrae <[email protected]>
Adds the compliance checks that are being used in sdk-nrf Signed-off-by: Jamie McCrae <[email protected]>
test DNR Signed-off-by: Jamie McCrae <[email protected]>
8fdf0e4
to
9bd83a5
Compare
@nordicjm I assume there are PRs to memfault etc. that fixes the compliance issues seen here now. I cannot see anything related to this repo. |
The various groups are responsible for fixing them, they have been asked to fix them, and those tasks are listed under |