workflow: compliance: Use additional compliance checks #410
Conversation
nordicjm
commented
Oct 3, 2025
nordicjm
commented
|
The following west manifest projects have changed revision in this Pull Request:
Additional metadata changed:
⛔ DNM label due to: 1 project with metadata changes Note: This message is automatically posted and updated by the Manifest GitHub Action. |
|
You can find the documentation preview for this PR here. |
.github/workflows/compliance.yml
Outdated
|
|
||
| - name: check-warns | ||
| working-directory: nrf-bm | ||
| working-directory: ncs/nrf |
There was a problem hiding this comment.
Should this be nrf-bm?
nordicjm
force-pushed
the
compliancechecks
branch
from
1dc5073 to
fe8d839
Compare
nordicjm
force-pushed
the
compliancechecks
branch
3 times, most recently
from
2838e73 to
8fdf0e4
Compare
|
@rghaddab @eivindj-nordic @MirkoCovizzi Please see and fix Kconfig compliance issues on https://github.com/nrfconnect/sdk-nrf-bm/actions/runs/18221678088?pr=410 |
Opened #413. |
MirkoCovizzi
left a comment
MirkoCovizzi
left a comment
There was a problem hiding this comment.
Looks good to me when compared to the NCS one.
eivindj-nordic
left a comment
eivindj-nordic
left a comment
There was a problem hiding this comment.
@nordicjm Please rebase, or were you planning to add further updates to this PR?
nordicjm
force-pushed
the
compliancechecks
branch
from
8fdf0e4 to
9bd83a5
Compare
|
@nordicjm I assume there are PRs to memfault etc. that fixes the compliance issues seen here now. I cannot see anything related to this repo. |
The various groups are responsible for fixing them, they have been asked to fix them, and those tasks are listed under |
Removes enable text from a Kconfig option Signed-off-by: Jamie McCrae <[email protected]>
Includes changes in compliance CI checks Signed-off-by: Jamie McCrae <[email protected]>
Adds files that are generated as part of compliance checks to the .gitignore list Signed-off-by: Jamie McCrae <[email protected]>
nordicjm
force-pushed
the
compliancechecks
branch
from
9bd83a5 to
f8dfa2e
Compare
Adds the compliance checks that are being used in sdk-nrf, also reworks the compliance script to match how it works in NCS. Unfortunately for Kconfig compliance tests to pass, some NCS-only modules are needed due to there being usage of Kconfigs defined in these modules in the NCS tree so the compliance job needs to patch the manifest first so include these additional modules to allow the compliance tests to run and pass Signed-off-by: Jamie McCrae <[email protected]>
nordicjm
force-pushed
the
compliancechecks
branch
from
f8dfa2e to
e5f5211
Compare
4 participants
