-
Notifications
You must be signed in to change notification settings - Fork 21
treewide: bluetooth: change error codes to nrf_error #437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
eivindj-nordic
wants to merge
11
commits into
nrfconnect:main
Choose a base branch
from
eivindj-nordic:error_code_alignment_ble_conn_param
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
treewide: bluetooth: change error codes to nrf_error #437
eivindj-nordic
wants to merge
11
commits into
nrfconnect:main
from
eivindj-nordic:error_code_alignment_ble_conn_param
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You can find the documentation preview for this PR here. |
a3bc308
to
0c2e340
Compare
Change error codes to nrf_errors. Signed-off-by: Eivind Jølsgard <[email protected]>
2d887e6
to
650db0b
Compare
Removed a compliance warning. Signed-off-by: Eivind Jølsgard <[email protected]>
650db0b
to
ac40aef
Compare
Rename nrf error variables from err to nrf_err. Align success checks for nrf_errors. Replace (nrf_err != NRF_SUCCESS) with (nrf_err). Signed-off-by: Eivind Jølsgard <[email protected]>
Change error codes to nrf_errors. Signed-off-by: Eivind Jølsgard <[email protected]>
599d5ac
to
f7a56dc
Compare
Change error codes to nrf_errors. Signed-off-by: Eivind Jølsgard <[email protected]>
Change error codes to nrf_errors. Signed-off-by: Eivind Jølsgard <[email protected]>
Change error codes to nrf_errors. Signed-off-by: Eivind Jølsgard <[email protected]>
Change error codes to nrf_errors. Signed-off-by: Eivind Jølsgard <[email protected]>
Change error codes to nrf_errors. Cleanup of ble_dis header. Signed-off-by: Eivind Jølsgard <[email protected]>
Change error codes to nrf_errors. Signed-off-by: Eivind Jølsgard <[email protected]>
Change error codes to nrf_errors. Signed-off-by: Eivind Jølsgard <[email protected]>
f7a56dc
to
965ce66
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
changelog-entry-required
Update changelog before merge. Remove label if entry is not needed or already added.
doc-required
PR must not be merged without tech writer approval.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress.
#depends on #436
Change error codes to nrf_errors.
Moving forward all non-BLE libraries and components will return errnos, while BLE related code as BLE services, libraries and the SoftDevice will return nrf_errors.