Skip to content

Peer Manager typedef removal and some refactoring #438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 27 commits into
base: main
Choose a base branch
from
Open

Peer Manager typedef removal and some refactoring #438

wants to merge 27 commits into from

Conversation

anhmolt
Copy link
Contributor

@anhmolt anhmolt commented Oct 22, 2025

Typedef removal from PM API and internal. Plus some refactoring.

  • squash the typedef removal commits to one or two commits when review is done.

anhmolt added 27 commits October 22, 2025 17:22
@anhmolt
include: bluetooth: peer_manager: place const before storage type
d37ff6f 
Peer manager API was earlier aligned to having const keyword
before the parameter storage type. This one slipped through.

Signed-off-by: Andreas Moltumyr <[email protected]>
@anhmolt
lib: peer_manager: Log peers delete successful as info and not error
8dd756a 
Having successfully deleted data is not an error.

Signed-off-by: Andreas Moltumyr <[email protected]>
@anhmolt
lib: peer_manager: use uint16_t in place of pm_peer_id_t
853e362 
Using a typedef for the peer_id type does not really
improve readability or give anything. Replace with
the actual storage type.

Signed-off-by: Andreas Moltumyr <[email protected]>
@anhmolt
lib: peer_manager: use uint32_t in place of pm_store_token_t
aeb56f8 
Using a typedef for the store token does not really
improve readability or give anything. Replace with
the actual storage type.

Signed-off-by: Andreas Moltumyr <[email protected]>
@anhmolt
lib: peer_manager: use uint16_t in place of pm_sec_error_code_t
8754caa 
Using a typedef for the security error does not really
improve readability or give anything. Replace with
the actual storage type.

Signed-off-by: Andreas Moltumyr <[email protected]>
@anhmolt
lib: peer_manager: remove ble_gatt_db typedefs
8947b36 
Change
ble_gatt_db_srv_t  -> struct ble_gatt_db_srv
ble_gatt_db_char_t -> struct ble_gatt_db_char
to align with NCS code style.

Signed-off-by: Andreas Moltumyr <[email protected]>
@anhmolt
lib: peer_manager: remove typedef for peer_id_list_skip enum
e87a166 
Change pm_peer_id_list_skip_t to enum pm_peer_id_list_skip
to align with NCS code style.

Signed-off-by: Andreas Moltumyr <[email protected]>
@anhmolt
lib: peer_manager: remove typedef for pm_peer_data_id enum
eec64ee 
Change pm_peer_data_id_t to enum pm_peer_data_id
to align with NCS code style.

Signed-off-by: Andreas Moltumyr <[email protected]>
@anhmolt
lib: peer_manager: remove typedef for pm_conn_sec_procedure enum
7ddcd8e 
Change pm_conn_sec_procedure_t to enum pm_conn_sec_procedure
to align with NCS code style.

Signed-off-by: Andreas Moltumyr <[email protected]>
@anhmolt
lib: peer_manager: remove typedef for pm_conn_sec_config struct
d85617d 
Change pm_conn_sec_config_t to struct pm_conn_sec_config
to align with NCS code style.

Signed-off-by: Andreas Moltumyr <[email protected]>
@anhmolt
lib: peer_manager: remove typedef for pm_peer_data_bonding struct
d9ec184 
Change pm_peer_data_bonding_t to struct pm_peer_data_bonding
to align with NCS code style.

Signed-off-by: Andreas Moltumyr <[email protected]>
@anhmolt
lib: peer_manager: remove typedef for pm_peer_data_local_gatt_db struct
5abfdfc 
Change pm_peer_data_local_gatt_db_t to
struct pm_peer_data_local_gatt_db to align with NCS code style.

Signed-off-by: Andreas Moltumyr <[email protected]>
@anhmolt
lib: peer_manager: remove typedef pm_privacy_params_t
d9c4914 
Remove typedef pm_privacy_params_t and use ble_gap_privacy_params_t
directly in the peer_manager API. Docstrings for pm_privacy_params_t
is exactly the same as that of ble_gap_privacy_params_t in the
SoftDevice API.

Signed-off-by: Andreas Moltumyr <[email protected]>
@anhmolt
lib: peer_manager: remove typedef for pm_conn_sec_status struct
d89904d 
Change pm_conn_sec_status_t to struct pm_conn_sec_status
to align with NCS code style.

Signed-off-by: Andreas Moltumyr <[email protected]>
@anhmolt
lib: peer_manager: remove typedef for pm_evt_id enum
fcde01b 
Change pm_evt_id_t to enum pm_evt_id to align with NCS code style.

Signed-off-by: Andreas Moltumyr <[email protected]>
@anhmolt
lib: peer_manager: remove typedef for params of pm_evt_t
61a7a4a 
Remove typedefs for the params of pm_evt_t
to align with NCS code style.

Signed-off-by: Andreas Moltumyr <[email protected]>
@anhmolt
lib: peer_manager: remove typedef for pm_evt struct
ce43394 
Change pm_evt_t to struct pm_evt to align with NCS code style
and cleanup some code populating said event structure
with initializer array.

Signed-off-by: Andreas Moltumyr <[email protected]>
@anhmolt
lib: peer_manager: remove internal typedefs for structs and enums
543ecea 
Remove typedefs for structs and enums internally in peer_manager
to align with NCS code style.

Signed-off-by: Andreas Moltumyr <[email protected]>
@anhmolt
lib: peer_manager: move const keyword before storage type
2927765 
Place const keyword before the storage type to align with
the style for the repo.

Signed-off-by: Andreas Moltumyr <[email protected]>
@anhmolt
lib: peer_manager: rework mutex/atomic in gatt_cache_manager
026b34f 
Remove three helper functions by using the atomic API directly
in the other functions.

Signed-off-by: Andreas Moltumyr <[email protected]>
@anhmolt
lib: peer_manager: remove sdk_macros
4a4a27f 
The verification macros in sdk_macros.h was copied from nRF5 SDK
to support quicker porting of the peer_manager and was never intended
to persist long in nRF Bare Metal option.
This removes the sdk_macros.h header file and substitutes the logic
where the VERIFY_xxx macros were used. This preserves the logic.

Signed-off-by: Andreas Moltumyr <[email protected]>
@anhmolt
lib: peer_manager: id_manager: wrong wlist_addr_cnt input value
69289fd 
When enabling the debug checks (asserts), a value of zero for
wlist_addr_cnt triggers an assert in the peers_id_keys_get()
function. Correct it to the number of addresses that can be held
in the local addrs array passed to the peers_id_keys_get() function.

For context, on return from peers_id_keys_get(), the wlist_addr_cnt
will hold the number of addresses written to the addrs array.

Signed-off-by: Andreas Moltumyr <[email protected]>
@anhmolt
lib: peer_manager: remove NRF_PM_DEBUG_CHECK and use assert
b6829ad 
Use of macro NRF_PM_DEBUG_CHECK is from nRF5 SDK and was never
intended to be kept for long. Remove the NRF_PM_DEBUG_CHECK
debug check macro and use the zephyr asserts module inplace of it.

Signed-off-by: Andreas Moltumyr <[email protected]>
@anhmolt
lib: peer_manager: small include header cleanup
d6c082f 
Cleanup some header includes in peer_manager internal headers.

Signed-off-by: Andreas Moltumyr <[email protected]>
@anhmolt
lib: peer_manager: fixes for PM_HANDLER_SEC_DELAY_MS greater than zero
1f8711e 
Fix code that is only compiled when CONFIG_PM_HANDLER_SEC_DELAY_MS > 0.
Fixes an assert, a missing "address of" symbol and adds a void type
cast for the error passed to APP_ERROR_CHECK macro to
silence a warning.

Signed-off-by: Andreas Moltumyr <[email protected]>
@anhmolt
lib: peer_manager: cleanup pm handler sec delay functionality
a02ba8e 
* Rename function _conn_secure to conn_secure_impl to avoid having
  a function starting with an underscore.
* Comment that the context pointer for the delay timer holds the data
  itself and does not hold a valid address.
* Place the CONFIG_PM_HANDLER_SEC_DELAY_MS preprocessor conditional
  inside of the conn_secure function so there exists only one signature
  for the function.

Signed-off-by: Andreas Moltumyr <[email protected]>
@anhmolt
lib: peer_manager: remove hungarian notation in internal module files
681b024 
Remove hungarian notation, that is p_ and m_ from internal
peer_manager files.

Signed-off-by: Andreas Moltumyr <[email protected]>
@anhmolt anhmolt requested review from a team as code owners October 22, 2025 15:28
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Oct 22, 2025
@github-actions github-actions bot added the doc-required PR must not be merged without tech writer approval. label Oct 22, 2025
@github-actions
Copy link

You can find the documentation preview for this PR here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. doc-required PR must not be merged without tech writer approval.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@anhmolt