lib: bluetooth: ble_adv: fix allow list advertising without directed advertising enabled #561
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With allow-list enabled, and directed and/or directed high duty advertising disabled in Kconfig, the allow-list for use in fast and slow advertising did not take effect when advertising was started with mode directed or directed high duty. This made it possible for non-paired/non-allow-listed devices to connect after a paired/allow-listed device had disconnected and advertising had been automatically restarted in the directed high duty mode. This fixes two internal checks in the ble_adv library that was the source of the issue. These checks will now correctly return the "capabilities" of the advertising mode to be started so that the configuration will be correct. Signed-off-by: Andreas Moltumyr <[email protected]>
github-actions
bot
added
the
doc-required
|
You can find the documentation preview for this PR here. |
peknis
approved these changes
Dec 10, 2025
When configuring the advertisement set for direct advertisement with sd_ble_gap_adv_set_configure(), NULL must be passed for the advertising data argument because advertising data is not supported in this mode. The sd_ble_gap_adv_set_configure() would return NRF_ERROR_INVALID_PARAM in this case. When doing directed advertisement, the address of the peer to direct the advertisement towards needed to be specified in the advertisement parameters when calling sd_ble_gap_adv_set_configure(). Set the address in the advertisement parameters to the address supplied by the application calling the ble_adv_peer_addr_reply() function in response to the BLE_ADV_EVT_PEER_ADDR_REQUEST event. Signed-off-by: Andreas Moltumyr <[email protected]>
anhmolt
force-pushed
the
fix-advertising-with-allow-list
branch
from
1eedd9c to
5b20a6e
Compare
Contributor
Author
|
Added another commit because of another bug. @peknis, please have a look at the changelog again. I have added a second entry. |
peknis
approved these changes
Dec 11, 2025
lemrey
approved these changes
Dec 11, 2025
eivindj-nordic
approved these changes
Dec 11, 2025
b-gent
approved these changes
Dec 11, 2025
marenges
approved these changes
Dec 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.