bluetooth: subsys: samples: clarify BMS auth code Kconfig scope#641
Open
PizzaAllTheWay wants to merge 2 commits intonrfconnect:mainfrom
Open
bluetooth: subsys: samples: clarify BMS auth code Kconfig scope#641PizzaAllTheWay wants to merge 2 commits intonrfconnect:mainfrom
PizzaAllTheWay wants to merge 2 commits intonrfconnect:mainfrom
Conversation
github-actions
bot
added
changelog-entry-required
|
You can find the documentation preview for this PR here. |
samples/bluetooth/ble_bms/README.rst
Outdated
|
|
||
| Authorization codes up to **127 bytes** are supported. You may configure the code to any value within this limit as needed. | ||
|
|
||
| If this security feature is not required, it can be enabled or disabled using `BLE_BMS_USE_AUTHORIZATION_CODE` in the same Kconfig file. After changing the configuration, rebuild the sample and test how bond deletion behaves with or without an authorization code. |
Contributor
There was a problem hiding this comment.
Suggested change
| If this security feature is not required, it can be enabled or disabled using `BLE_BMS_USE_AUTHORIZATION_CODE` in the same Kconfig file. After changing the configuration, rebuild the sample and test how bond deletion behaves with or without an authorization code. | |
| If this security feature is not required, it can be enabled or disabled using the :kconfig:option:`CONFIG_APP_BLE_BMS_USE_AUTHORIZATION_CODE` Kconfig option. After changing the configuration, rebuild the sample and test how bond deletion behaves with or without an authorization code. |
PizzaAllTheWay
force-pushed
the
config-scope
branch
from
21608e9 to
a6085f9
Compare
samples/bluetooth/ble_bms/README.rst
Outdated
|
|
||
| Authorization codes up to **127 bytes** are supported. You may configure the code to any value within this limit as needed. | ||
|
|
||
| If this security feature is not required, it can be enabled or disabled using :kconfig:option:`APP_BLE_BMS_USE_AUTHORIZATION_CODE` in the same Kconfig file. After changing the configuration, rebuild the sample and test how bond deletion behaves with or without an authorization code. |
Contributor
There was a problem hiding this comment.
Suggested change
| If this security feature is not required, it can be enabled or disabled using :kconfig:option:`APP_BLE_BMS_USE_AUTHORIZATION_CODE` in the same Kconfig file. After changing the configuration, rebuild the sample and test how bond deletion behaves with or without an authorization code. | |
| If this security feature is not required, it can be enabled or disabled using the :kconfig:option:`APP_BLE_BMS_USE_AUTHORIZATION_CODE` Kconfig option. After changing the configuration, rebuild the sample and test how bond deletion behaves with or without an authorization code. |
PizzaAllTheWay
force-pushed
the
config-scope
branch
2 times, most recently
from
a8968fa to
218f7c1
Compare
github-actions
bot
removed
the
changelog-entry-required
nordicjm
reviewed
Feb 16, 2026
samples/bluetooth/ble_bms/Kconfig
Outdated
Comment on lines
17
to
23
| config APP_BLE_BMS_USE_AUTHORIZATION_CODE | ||
| bool "Use authorization code" | ||
| default y | ||
|
|
||
| config APP_BLE_BMS_AUTHORIZATION_CODE | ||
| string "Authorization code" | ||
| default "ABCD" |
Author
There was a problem hiding this comment.
@eivindj-nordic What do you think? This would require changing all Kconfig options in all samples to use the SAMPLE_ prefix, since all samples currently use the APP_ prefix.
Contributor
There was a problem hiding this comment.
We will create a separate PR to address this across the repository to match the new guidelines.
Contributor
There was a problem hiding this comment.
Opened #648. You can align this and other PRs to use the SAMPLE_ prefix too.
PizzaAllTheWay
force-pushed
the
config-scope
branch
from
e41105b to
13ac240
Compare
PizzaAllTheWay
force-pushed
the
config-scope
branch
3 times, most recently
from
45be5b2 to
ecf856d
Compare
The BMS authorization code configuration has been aligned with its actual usage by making it sample‑specific. CONFIG_BLE_BMS_AUTHORIZATION_CODE (and BLE_BMS_AUTHORIZATION_CODE) was previously defined at the BMS library level even though it is only used by the BLE BMS sample. This change clarifies the configuration scope and avoids confusion for users by ensuring the authorization code setting is defined and documented where it is actually applied. Signed-off-by: Martynas Smilingis <martynas.smilingis@nordicsemi.no>
clarified in changelog that CONFIG_BLE_BMS_AUTHORIZATION_CODE and CONFIG_BLE_BMS_USE_AUTHORIZATION_CODE have been moved to be sample specific. Signed-off-by: Martynas Smilingis <martynas.smilingis@nordicsemi.no>
PizzaAllTheWay
force-pushed
the
config-scope
branch
from
ecf856d to
86c1866
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The BMS authorization code configuration has been aligned with its actual usage by making it sample‑specific.
CONFIG_BLE_BMS_AUTHORIZATION_CODE (and BLE_BMS_AUTHORIZATION_CODE) was previously defined at the BMS library level even though it is only used by the BLE BMS sample. This change clarifies the configuration scope and avoids confusion for users by ensuring the authorization code setting is defined and documented where it is actually applied.