application: installer: added verification dealys infrastructre#654
Open
nvlsianpu wants to merge 1 commit intonrfconnect:mainfrom
Open
application: installer: added verification dealys infrastructre#654nvlsianpu wants to merge 1 commit intonrfconnect:mainfrom
nvlsianpu wants to merge 1 commit intonrfconnect:mainfrom
Conversation
github-actions
bot
added
the
changelog-entry-required
|
You can find the documentation preview for this PR here. |
nvlsianpu
force-pushed
the
cudo/ncsdk-37698
branch
2 times, most recently
from
2cbcfaa to
361a37e
Compare
nordicjm
requested changes
Feb 20, 2026
applications/installer/Kconfig
Outdated
| source "Kconfig.zephyr" | ||
|
|
||
| menuconfig APP_BM_INSTALLER_SELF_DELAYS | ||
| bool "Installers verification delays" |
Contributor
There was a problem hiding this comment.
missing [EXPERIMENTAL] in prompt
applications/installer/Kconfig
Outdated
| bool "Installers verification delays" | ||
| select EXPERIMENTAL | ||
| help | ||
| Means to be used for testing purposes |
Contributor
There was a problem hiding this comment.
Suggested change
| Means to be used for testing purposes | |
| For testing purposes only |
applications/installer/Kconfig
Outdated
| if APP_BM_INSTALLER_SELF_DELAYS | ||
|
|
||
| config APP_BM_INSTALLER_POST_METADATA_INVALIDATION_DELAY | ||
| int "delay after metadata invalidation [MS]" |
Contributor
There was a problem hiding this comment.
capitalise first letter, lowercase ms as that is a unit, and add unit to symbol e.g. APP_BM_INSTALLER_POST_METADATA_INVALIDATION_DELAY_MS
applications/installer/Kconfig
Outdated
| int "delay before self destruction [MS]" | ||
| default 1000 | ||
| help | ||
| The dealay after metadata update and before self destruction. |
applications/installer/src/main.c
Outdated
| } | ||
| } | ||
|
|
||
| /* Delay for reliability verification purpose*/ |
Contributor
There was a problem hiding this comment.
all are missing a space before */
nvlsianpu
force-pushed
the
cudo/ncsdk-37698
branch
from
361a37e to
d777bdc
Compare
Added configurable infrastructure for delay NVM memory operation. These delay are needed for making detail testing of the instalation interrupts possible. Kconfig added: * CONFIG_APP_BM_INSTALLER_SELF_DELAYS: Enable optional installer verification delays (testing); * CONFIG_APP_BM_INSTALLER_POST_METADATA_INVALIDATION_DELAY_MS: Delay [ms] after metadata invalidation, before image copy; emits LOG_INF "V_DELAY_POST_METADATA_INVALIDATION" before the delay. * CONFIG_APP_BM_INSTALLER_INTER_IMAGE_CHUNK_COPY_DELAY_MS: Delay [ms] between image chunk copies; emits LOG_INF "V_DELAY_IMAGE_CHUNK_COPY" before the delay. * CONFIG_APP_BM_INSTALLER_NEXT_IMAGE_COPY_DELAY_MS: Delay [ms] before next image copy; emits LOG_INF "V_DELAY_NEXT_IMAGE_COPY" before the delay. * CONFIG_APP_BM_INSTALLER_PRIOR_METADATA_UPDATE_DELAY_MS: Delay [ms] after image copy, before metadata update; emits LOG_INF "V_DELAY_METADATA_UPDATE" before the delay. * CONFIG_APP_BM_INSTALLER_PRIOR_SELF_DESTRUCTION_DELAY_MS: Delay [ms] before clearing installer header; emits LOG_INF "V_DELAY_SELF_DESTRUCTION" before the delay. Signed-off-by: Andrzej Puzdrowski <andrzej.puzdrowski@nordicsemi.no>
nvlsianpu
force-pushed
the
cudo/ncsdk-37698
branch
from
d777bdc to
5c96afe
Compare
michalek-no
approved these changes
Feb 20, 2026
nordicjm
approved these changes
Feb 20, 2026
lemrey
reviewed
Feb 20, 2026
| #define VERIFICATION_DELAY(x, msg) do { \ | ||
| LOG_INF(msg); \ | ||
| log_flush(); \ | ||
| k_busy_wait((x) * USEC_PER_MSEC); \ |
Contributor
There was a problem hiding this comment.
You can use k_sleep here; it either busy waits or WFI (after this commit)
fundakol
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref.: NCSDK-37698
Added configurable infrastructure for delay NVM memory operation. These delay are needed for making detail testing of the instalation interrupts possible.
Kconfig added:
CONFIG_APP_BM_INSTALLER_SELF_DELAYS: Enable optional installer verification delays (testing).
CONFIG_APP_BM_INSTALLER_POST_METADATA_INVALIDATION_DELAY_MS: Delay [ms] after metadata invalidation, before image copy; emits LOG_INF "V_DELAY_POST_METADATA_INVALIDATION" before the delay.
CONFIG_APP_BM_INSTALLER_INTER_IMAGE_CHUNK_COPY_DELAY_MS: Delay [ms] between image chunk copies;
emits LOG_INF "V_DELAY_IMAGE_CHUNK_COPY" before the delay.
CONFIG_APP_BM_INSTALLER_NEXT_IMAGE_COPY_DELAY_MS:
Delay [ms] before next image copy;
emits LOG_INF "V_DELAY_NEXT_IMAGE_COPY" before the delay.
CONFIG_APP_BM_INSTALLER_PRIOR_METADATA_UPDATE_DELAY_MS: Delay [ms] after image copy, before metadata update; emits LOG_INF "V_DELAY_METADATA_UPDATE" before the delay.
CONFIG_APP_BM_INSTALLER_PRIOR_SELF_DESTRUCTION_DELAY_MS: Delay [ms] before clearing installer header;
emits LOG_INF "V_DELAY_SELF_DESTRUCTION" before the delay.