Skip to content

tests: unit: ble_adv: improvements to ble_adv testcase configs #656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eivindj-nordic merged 2 commits into from
Feb 26, 2026
Merged

tests: unit: ble_adv: improvements to ble_adv testcase configs #656

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0a752c1
tests: unit: ble_adv: fix missing directed configs and cleanup
anhmolt Feb 23, 2026
b925db4
tests: unit: ble_adv: rework testcase logic
anhmolt Feb 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions tests/unit/lib/bluetooth/ble_adv/prj.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,7 @@
CONFIG_UNITY=y

# Disable all modes here so they can be consistently enabled in testcase.yaml.
CONFIG_BLE_ADV_DIRECTED_ADVERTISING_HIGH_DUTY=n
CONFIG_BLE_ADV_DIRECTED_ADVERTISING=n
CONFIG_BLE_ADV_FAST_ADVERTISING=n
CONFIG_BLE_ADV_SLOW_ADVERTISING=n
130 changes: 66 additions & 64 deletions tests/unit/lib/bluetooth/ble_adv/testcase.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,109 +3,111 @@ common:
platform_allow: native_sim
tags: unittest
Copy link
Contributor

@eivindj-nordic eivindj-nordic Feb 24, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a thought, will discuss offline, would it be an idea to turn off all modes in prj.conf, then enable everything here based on the test case? Could give a better overview of what is enabled for the different tests.

Copy link
Contributor Author

@anhmolt anhmolt Feb 24, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. The second commit now disables every advertising mode in prj.conf so that the desired modes can be (re)enabled in testcase.yaml. I think it should be more readable and maintainable now.

tests:
lib.ble_adv: {}
lib.ble_adv.no_directed_hd:
lib.ble_adv.mode_none: {}
lib.ble_adv.mode_slow:
extra_configs:
- CONFIG_BLE_ADV_DIRECTED_ADVERTISING=y
- CONFIG_BLE_ADV_DIRECTED_ADVERTISING_HIGH_DUTY=n
lib.ble_adv.no_fast:
- CONFIG_BLE_ADV_SLOW_ADVERTISING=y
lib.ble_adv.mode_fast:
extra_configs:
- CONFIG_BLE_ADV_FAST_ADVERTISING=n
- CONFIG_BLE_ADV_DIRECTED_ADVERTISING=y
lib.ble_adv.no_slow:
- CONFIG_BLE_ADV_FAST_ADVERTISING=y
lib.ble_adv.mode_fast_slow:
extra_configs:
- CONFIG_BLE_ADV_SLOW_ADVERTISING=n
- CONFIG_BLE_ADV_DIRECTED_ADVERTISING=y
lib.ble_adv.no_directed_hd_or_fast:
- CONFIG_BLE_ADV_FAST_ADVERTISING=y
- CONFIG_BLE_ADV_SLOW_ADVERTISING=y
lib.ble_adv.mode_directed:
extra_configs:
- CONFIG_BLE_ADV_DIRECTED_ADVERTISING_HIGH_DUTY=n
- CONFIG_BLE_ADV_FAST_ADVERTISING=n
lib.ble_adv.no_directed_hd_or_slow:
extra_configs:
- CONFIG_BLE_ADV_DIRECTED_ADVERTISING_HIGH_DUTY=n
- CONFIG_BLE_ADV_SLOW_ADVERTISING=n
lib.ble_adv.no_directed_or_fast:
- CONFIG_BLE_ADV_DIRECTED_ADVERTISING=y
lib.ble_adv.mode_directed_slow:
extra_configs:
- CONFIG_BLE_ADV_FAST_ADVERTISING=n
lib.ble_adv.no_directed_or_slow:
- CONFIG_BLE_ADV_DIRECTED_ADVERTISING=y
- CONFIG_BLE_ADV_SLOW_ADVERTISING=y
lib.ble_adv.mode_directed_fast:
extra_configs:
- CONFIG_BLE_ADV_SLOW_ADVERTISING=n
lib.ble_adv.no_fast_or_slow:
- CONFIG_BLE_ADV_DIRECTED_ADVERTISING=y
- CONFIG_BLE_ADV_FAST_ADVERTISING=y
lib.ble_adv.mode_directed_fast_slow:
extra_configs:
- CONFIG_BLE_ADV_DIRECTED_ADVERTISING=y
- CONFIG_BLE_ADV_FAST_ADVERTISING=n
- CONFIG_BLE_ADV_SLOW_ADVERTISING=n
lib.ble_adv.no_directed_hd_or_fast_or_slow:
- CONFIG_BLE_ADV_FAST_ADVERTISING=y
- CONFIG_BLE_ADV_SLOW_ADVERTISING=y
lib.ble_adv.mode_dhd_directed:
extra_configs:
- CONFIG_BLE_ADV_DIRECTED_ADVERTISING_HIGH_DUTY=y
- CONFIG_BLE_ADV_DIRECTED_ADVERTISING=y
- CONFIG_BLE_ADV_DIRECTED_ADVERTISING_HIGH_DUTY=n
- CONFIG_BLE_ADV_FAST_ADVERTISING=n
- CONFIG_BLE_ADV_SLOW_ADVERTISING=n
lib.ble_adv.no_directed_or_fast_or_slow:
lib.ble_adv.mode_dhd_directed_slow:
extra_configs:
- CONFIG_BLE_ADV_FAST_ADVERTISING=n
- CONFIG_BLE_ADV_SLOW_ADVERTISING=n

lib.ble_adv.directed:
- CONFIG_BLE_ADV_DIRECTED_ADVERTISING_HIGH_DUTY=y
- CONFIG_BLE_ADV_DIRECTED_ADVERTISING=y
- CONFIG_BLE_ADV_SLOW_ADVERTISING=y
lib.ble_adv.mode_dhd_directed_fast:
extra_configs:
- CONFIG_BLE_ADV_DIRECTED_ADVERTISING_HIGH_DUTY=y
- CONFIG_BLE_ADV_DIRECTED_ADVERTISING=y
lib.ble_adv.use_allow_list:
- CONFIG_BLE_ADV_FAST_ADVERTISING=y
lib.ble_adv.mode_dhd_directed_fast_slow:
extra_configs:
- CONFIG_BLE_ADV_DIRECTED_ADVERTISING_HIGH_DUTY=y
- CONFIG_BLE_ADV_DIRECTED_ADVERTISING=y
- CONFIG_BLE_ADV_FAST_ADVERTISING=y
- CONFIG_BLE_ADV_SLOW_ADVERTISING=y

lib.ble_adv.use_allow_list_mode_none:
extra_configs:
- CONFIG_BLE_ADV_USE_ALLOW_LIST=y
lib.ble_adv.use_allow_list_no_directed_hd:
lib.ble_adv.use_allow_list_mode_slow:
extra_configs:
- CONFIG_BLE_ADV_USE_ALLOW_LIST=y
- CONFIG_BLE_ADV_DIRECTED_ADVERTISING=y
- CONFIG_BLE_ADV_DIRECTED_ADVERTISING_HIGH_DUTY=n
lib.ble_adv.use_allow_list_no_directed:
- CONFIG_BLE_ADV_SLOW_ADVERTISING=y
lib.ble_adv.use_allow_list_mode_fast:
extra_configs:
- CONFIG_BLE_ADV_USE_ALLOW_LIST=y
lib.ble_adv.use_allow_list_no_fast:
- CONFIG_BLE_ADV_FAST_ADVERTISING=y
lib.ble_adv.use_allow_list_mode_fast_slow:
extra_configs:
- CONFIG_BLE_ADV_DIRECTED_ADVERTISING=y
- CONFIG_BLE_ADV_USE_ALLOW_LIST=y
- CONFIG_BLE_ADV_FAST_ADVERTISING=n
lib.ble_adv.use_allow_list_no_slow:
- CONFIG_BLE_ADV_FAST_ADVERTISING=y
- CONFIG_BLE_ADV_SLOW_ADVERTISING=y
lib.ble_adv.use_allow_list_mode_directed:
extra_configs:
- CONFIG_BLE_ADV_DIRECTED_ADVERTISING=y
- CONFIG_BLE_ADV_USE_ALLOW_LIST=y
- CONFIG_BLE_ADV_SLOW_ADVERTISING=n
lib.ble_adv.use_allow_list_no_directed_hd_or_fast:
- CONFIG_BLE_ADV_DIRECTED_ADVERTISING=y
lib.ble_adv.use_allow_list_mode_directed_slow:
extra_configs:
- CONFIG_BLE_ADV_USE_ALLOW_LIST=y
- CONFIG_BLE_ADV_DIRECTED_ADVERTISING=y
- CONFIG_BLE_ADV_DIRECTED_ADVERTISING_HIGH_DUTY=n
- CONFIG_BLE_ADV_FAST_ADVERTISING=n
lib.ble_adv.use_allow_list_no_directed_hd_or_slow:
- CONFIG_BLE_ADV_SLOW_ADVERTISING=y
lib.ble_adv.use_allow_list_mode_directed_fast:
extra_configs:
- CONFIG_BLE_ADV_USE_ALLOW_LIST=y
- CONFIG_BLE_ADV_DIRECTED_ADVERTISING=y
- CONFIG_BLE_ADV_DIRECTED_ADVERTISING_HIGH_DUTY=n
- CONFIG_BLE_ADV_SLOW_ADVERTISING=n
lib.ble_adv.use_allow_list_no_directed_or_fast:
- CONFIG_BLE_ADV_FAST_ADVERTISING=y
lib.ble_adv.use_allow_list_mode_directed_fast_slow:
extra_configs:
- CONFIG_BLE_ADV_USE_ALLOW_LIST=y
- CONFIG_BLE_ADV_FAST_ADVERTISING=n
lib.ble_adv.use_allow_list_no_directed_or_slow:
- CONFIG_BLE_ADV_DIRECTED_ADVERTISING=y
- CONFIG_BLE_ADV_FAST_ADVERTISING=y
- CONFIG_BLE_ADV_SLOW_ADVERTISING=y
lib.ble_adv.use_allow_list_mode_dhd_directed:
extra_configs:
- CONFIG_BLE_ADV_USE_ALLOW_LIST=y
- CONFIG_BLE_ADV_SLOW_ADVERTISING=n
lib.ble_adv.use_allow_list_no_fast_or_slow:
- CONFIG_BLE_ADV_DIRECTED_ADVERTISING_HIGH_DUTY=y
- CONFIG_BLE_ADV_DIRECTED_ADVERTISING=y
lib.ble_adv.use_allow_list_mode_dhd_directed_slow:
extra_configs:
- CONFIG_BLE_ADV_USE_ALLOW_LIST=y
- CONFIG_BLE_ADV_DIRECTED_ADVERTISING_HIGH_DUTY=y
- CONFIG_BLE_ADV_DIRECTED_ADVERTISING=y
- CONFIG_BLE_ADV_FAST_ADVERTISING=n
- CONFIG_BLE_ADV_SLOW_ADVERTISING=n
lib.ble_adv.use_allow_list_no_directed_hd_or_fast_or_slow:
- CONFIG_BLE_ADV_SLOW_ADVERTISING=y
lib.ble_adv.use_allow_list_mode_dhd_directed_fast:
extra_configs:
- CONFIG_BLE_ADV_USE_ALLOW_LIST=y
- CONFIG_BLE_ADV_DIRECTED_ADVERTISING_HIGH_DUTY=y
- CONFIG_BLE_ADV_DIRECTED_ADVERTISING=y
- CONFIG_BLE_ADV_DIRECTED_ADVERTISING_HIGH_DUTY=n
- CONFIG_BLE_ADV_FAST_ADVERTISING=n
- CONFIG_BLE_ADV_SLOW_ADVERTISING=n
lib.ble_adv.use_allow_list_no_directed_or_fast_or_slow:
- CONFIG_BLE_ADV_FAST_ADVERTISING=y
lib.ble_adv.use_allow_list_mode_dhd_directed_fast_slow:
extra_configs:
- CONFIG_BLE_ADV_USE_ALLOW_LIST=y
- CONFIG_BLE_ADV_FAST_ADVERTISING=n
- CONFIG_BLE_ADV_SLOW_ADVERTISING=n
- CONFIG_BLE_ADV_DIRECTED_ADVERTISING_HIGH_DUTY=y
- CONFIG_BLE_ADV_DIRECTED_ADVERTISING=y
- CONFIG_BLE_ADV_FAST_ADVERTISING=y
- CONFIG_BLE_ADV_SLOW_ADVERTISING=y
Loading