lib: pdn: Fix handling of APN rate control and malformed +CGEV

+CGEV: APNRATECTRL STAT can also have status 2, which means that
no APN rate control is configured for the CID. Fixed the
implementation to map this to PDN_EVENT_APN_RATE_CONTROL_OFF event
instead of PDN_EVENT_APN_RATE_CONTROL_ON.

Fixed handling of malformed +CGEV notifications where the CID can
not be parsed. Earlier these caused the malformed event to be sent
for all PDNs. Only PDN_EVENT_NETWORK_DETACH is intended to be sent
for all PDNs, because the AT notification does not contain a CID
and it affects all PDNs.

Signed-off-by: Tommi Kangas <[email protected]>

Author: tokangas

doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst

@@ -688,6 +688,13 @@ Modem libraries
   * Added the :c:func:`nrf_modem_lib_trace_peek_at` function to the :c:struct:`nrf_modem_lib_trace_backend` interface to peek trace data at a byte offset without consuming it.
     Support for this API has been added to the flash trace backend.
 
+* :ref:`pdn_readme` library:
+
+  * Fixed:
+
+    * An issue where wrong APN rate control event was sent.
+    * An issue where a malformed +CGEV notification was not handled correctly.
+
 Multiprotocol Service Layer libraries
 -------------------------------------
 

lib/pdn/pdn.c

@@ -206,7 +206,8 @@ static void parse_cgev(const char *notif)
 		}
 
 		SYS_SLIST_FOR_EACH_CONTAINER(&pdn_contexts, pdn, node) {
-			if (pdn->callback && (pdn->context_id == cid || cid == CID_UNASSIGNED)) {
+			if (pdn->callback &&
+			    (pdn->context_id == cid || map[i].event == PDN_EVENT_NETWORK_DETACH)) {
 				pdn->callback(pdn->context_id, map[i].event, 0);
 			}
 		}
@@ -240,8 +241,8 @@ static void parse_cgev_apn_rate_ctrl(const char *notif)
 	SYS_SLIST_FOR_EACH_CONTAINER(&pdn_contexts, pdn, node) {
 		if (pdn->callback && pdn->context_id == cid) {
 			pdn->callback(pdn->context_id,
-				      apn_rate_ctrl_status ? PDN_EVENT_APN_RATE_CONTROL_ON
-							   : PDN_EVENT_APN_RATE_CONTROL_OFF,
+				      apn_rate_ctrl_status == 1 ? PDN_EVENT_APN_RATE_CONTROL_ON
+								: PDN_EVENT_APN_RATE_CONTROL_OFF,
 				      0);
 		}
 	}

tests/lib/pdn/src/main.c

@@ -1235,6 +1235,13 @@ void test_pdn_deactivate(void)
 	TEST_ASSERT_EQUAL(PDN_EVENT_DEACTIVATED, pdn_evt_event);
 }
 
+void test_detach(void)
+{
+	on_cgev("+CGEV: NW DETACH\r\n");
+
+	TEST_ASSERT_EQUAL(CID_1, pdn_evt_cid);
+	TEST_ASSERT_EQUAL(PDN_EVENT_NETWORK_DETACH, pdn_evt_event);
+}
 
 void test_pdn_id_get_eshutdown(void)
 {
@@ -1346,6 +1353,19 @@ void test_pdn_apn_rate_control_deactivate(void)
 	TEST_ASSERT_EQUAL(PDN_EVENT_APN_RATE_CONTROL_OFF, pdn_evt_event);
 }
 
+void test_pdn_apn_rate_control_not_configured(void)
+{
+	on_cgev("+CGEV: APNRATECTRL STAT 2,2");
+	/* no callback */
+	TEST_ASSERT_EQUAL(0, pdn_evt_cid);
+	TEST_ASSERT_EQUAL(0, pdn_evt_event);
+
+	on_cgev("+CGEV: APNRATECTRL STAT 1,2");
+
+	TEST_ASSERT_EQUAL(CID_1, pdn_evt_cid);
+	TEST_ASSERT_EQUAL(PDN_EVENT_APN_RATE_CONTROL_OFF, pdn_evt_event);
+}
+
 void test_pdn_ctx_destroy_einval(void)
 {
 	int ret;