Skip to content

Commit 9edeaa4

Browse files
rugeGerritsengmarull
authored andcommitted
CODEOWNERS: Add @nrfconnect/ncs-merge as owner for west.yml
The following scenarion happens quite often: 1. A PR is created to a subrepo referenced in the west.yml 2. The PR is reviewed. It is merged by someone in @nrfconnect/ncs-merge. 3. The PR to sdk-nrf cannot be merged until someone in @nrfconnect/ncs-code-owners approves it. This adds additional dependencies and increases the time to integrate the change done in the subrepo. Because the sub-PR was anyways merged by someone in @nrfconnect/ncs-merge, it seems unreasonable that these people cannot also merge the manifest-PR. Another alternatives: 1. Always require an approval from @nrfconnect/ncs-code-owners for any PR to any subrepo. This seems unreasonable. 2. Always wait for someone in @nrfconnect/ncs-code-owners to approve the (unfinished, pointing to PR) west.yml before merging the sub-PR. This seems unreasonable because the west.yml-PR is not done, and it may also increase delays. 3. Always wait from someone in @nrfconnect/ncs-code-owners to get the PR to sdk-nrf merged. This may increase delays and leaving NCS in a half-merged state where the subPR is merged, but the manifest-PR is not. This may increase the risk of ending up in a state where incompatible changes are merged. Signed-off-by: Rubin Gerritsen <[email protected]>
1 parent ea3378e commit 9edeaa4

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

CODEOWNERS

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
/LICENSE @carlescufi
1919
/README.rst @carlescufi @nrfconnect/ncs-doc-leads
2020
/VERSION @nrfconnect/ncs-code-owners
21-
/west.yml @nrfconnect/ncs-code-owners
21+
/west.yml @nrfconnect/ncs-code-owners @nrfconnect/ncs-merge
2222
/west-test.yml @nrfconnect/ncs-ci
2323

2424
# Dot folders

0 commit comments

Comments
 (0)