Remove deprecated RAI socket options #16468
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MirkoCovizzi
requested review from
MarkusLassila,
SeppoTakalo,
jhirsi,
lemrey,
rlubos,
tokangas,
tomi-font and
trantanen
as code owners
github-actions
bot
added
the
changelog-entry-required
Contributor
Test specificationCI/Jenkins/NRF
CI/Jenkins/integration
Detailed information of selected test modules Note: This message is automatically posted and updated by the CI |
Contributor
|
If it's a WIP can you put the PR in draft mode and/or add reviewers once it's ready for review? |
MirkoCovizzi
force-pushed
the
rm-rai-depr
branch
from
5619421 to
b55cdc7
Compare
MirkoCovizzi
changed the title
MirkoCovizzi
force-pushed
the
rm-rai-depr
branch
from
b55cdc7 to
887c014
Compare
github-actions
bot
added
doc-required
MirkoCovizzi
force-pushed
the
rm-rai-depr
branch
from
887c014 to
f9fdc02
Compare
Contributor
|
You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds. Note: This comment is automatically posted by the Documentation Publishing GitHub Action. |
tomi-font
requested changes
Jul 16, 2024
Contributor
There was a problem hiding this comment.
Please update the documentation accordingly: https://docs.nordicsemi.com/bundle/ncs-latest/page/nrf/applications/serial_lte_modem/doc/SOCKET_AT_commands.html#d197e2708
tomi-font
requested changes
Jul 16, 2024
Contributor
There was a problem hiding this comment.
This rather belongs to the migration guide.
Contributor
There was a problem hiding this comment.
Great. This could now be removed from here in my opinion.
MirkoCovizzi
force-pushed
the
rm-rai-depr
branch
2 times, most recently
from
44e696e to
8616e50
Compare
MirkoCovizzi
force-pushed
the
rm-rai-depr
branch
from
8616e50 to
55c6e4e
Compare
tomi-font
approved these changes
Jul 17, 2024
trantanen
approved these changes
Jul 22, 2024
SeppoTakalo
approved these changes
Jul 22, 2024
lemrey
approved these changes
Jul 22, 2024
divipillai
reviewed
Aug 5, 2024
doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst
Outdated
Show resolved
Hide resolved
doc/nrf/releases_and_maturity/migration/migration_guide_2.8.rst
Outdated
Show resolved
Hide resolved
doc/nrf/releases_and_maturity/migration/migration_guide_2.8.rst
Outdated
Show resolved
Hide resolved
MirkoCovizzi
force-pushed
the
rm-rai-depr
branch
from
7bc952e to
304e5b2
Compare
divipillai
approved these changes
Aug 6, 2024
MirkoCovizzi
force-pushed
the
rm-rai-depr
branch
2 times, most recently
from
2e7ed74 to
ea713e0
Compare
MarkusLassila
approved these changes
Aug 7, 2024
tokangas
approved these changes
Aug 7, 2024
MirkoCovizzi
force-pushed
the
rm-rai-depr
branch
3 times, most recently
from
216a9ad to
1c5e67f
Compare
Remove deprecated RAI socket options. Signed-off-by: Mirko Covizzi <[email protected]>
Remove deprecated RAI socket options. Signed-off-by: Mirko Covizzi <[email protected]>
Remove deprecated RAI socket options. Signed-off-by: Mirko Covizzi <[email protected]>
MirkoCovizzi
force-pushed
the
rm-rai-depr
branch
from
1c5e67f to
2e77991
Compare
Pull in changes related to removal of deprecated RAI socket options. Signed-off-by: Mirko Covizzi <[email protected]>
MirkoCovizzi
force-pushed
the
rm-rai-depr
branch
from
2e77991 to
d0845b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove deprecated RAI socket options.