Nrfx 6118 add icbmsg to egpio #17321

magp-nordic · 2024-09-13T15:53:04Z

~~Based on #16592, please, review only the last 5 commits.~~
Rebased on main.
PRs that affect this one:
~~#17669~~ (aligned)
~~#17173~~ (aligned)

NordicBuilder · 2024-09-13T15:53:38Z

The following west manifest projects have been modified in this Pull Request:

Name	Old Revision	New Revision	Diff
zephyr	nrfconnect/sdk-zephyr@`8005d4e`	nrfconnect/sdk-zephyr#2003	nrfconnect/sdk-zephyr#2003/files

Note: This message is automatically posted and updated by the Manifest GitHub Action.

NordicBuilder · 2024-09-13T16:02:12Z

CI Information

^{To view the history of this post, clich the 'edited' button above}
Build number: 16

Inputs:

Sources:

sdk-nrf: PR head: 1c37e62d40e8f1068eec7a1cb1409f6bcc5b1848

more details

sdk-nrf:

PR head: 1c37e62d40e8f1068eec7a1cb1409f6bcc5b1848
merge base: 63130153b694e33577eb2b83f8fab2ede0f336bc
target head (main): 936fc574d73dbbfc37ffaec3a87c00c940f2a685
Diff

Github labels

Enabled	Name	Description
	ci-disabled	Disable the ci execution
	ci-all-test	Run all of ci, no test spec filtering will be done
	ci-force-downstream	Force execution of downstream even if twister fails
	ci-run-twister	Force run twister
	ci-run-zephyr-twister	Force run zephyr twister

List of changed files detected by CI (18)

applications
│  ├── sdp
│  │  ├── gpio
│  │  │  ├── CMakeLists.txt
│  │  │  ├── boards
│  │  │  │  ├── nrf54l15dk_nrf54l15_cpuflpr.overlay
│  │  │  │  ├── nrf54l15dk_nrf54l15_cpuflpr_icbmsg.overlay
│  │  │  │  ├── nrf54l15dk_nrf54l15_cpuflpr_icmsg.overlay
│  │  │  │  │ nrf54l15dk_nrf54l15_cpuflpr_mbox.overlay
│  │  │  ├── sample.yaml
│  │  │  ├── src
│  │  │  │  ├── backend
│  │  │  │  │  │ backend.h
cmake
│  ├── sysbuild
│  │  │ sdp.cmake
drivers
│  ├── gpio
│  │  ├── CMakeLists.txt
│  │  ├── Kconfig
│  │  │ gpio_nrfe.h
scripts
│  ├── twister
│  │  ├── alt
│  │  │  ├── zephyr
│  │  │  │  ├── samples
│  │  │  │  │  ├── basic
│  │  │  │  │  │  ├── blinky
│  │  │  │  │  │  │  │ sample.yaml
snippets
│  ├── emulated-gpio
│  │  ├── icbmsg
│  │  │  ├── boards
│  │  │  │  │ nrf54l15dk_nrf54l15_cpuapp.overlay
│  │  │  ├── emulated-gpio.overlay
│  │  │  │ snippet.yml
sysbuild
│  │ Kconfig.sdp
tests
│  ├── drivers
│  │  ├── gpio
│  │  │  ├── egpio_basic_api
│  │  │  │  ├── src
│  │  │  │  │  │ test_egpio_port.c
│  │  │  │  │ testcase.yaml

Outputs:

Toolchain

Version: 3dd8985b56
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:3dd8985b56_912848a074

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

◻️ Toolchain - Skipped: existing toolchain is used
✅ Build twister - Skipped: Skipping Build & Test as it succeeded in a previous run: 14
✅ Integration tests
- ✅ test-sdk-audio - Skipped: Job was skipped as it succeeded in a previous run
- ✅ desktop52_verification - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-boot - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-apps - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test_ble_nrf_config - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-ble_mesh - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-ble_samples - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-chip - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-nfc - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-nrf-iot_cloud - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-nrf-iot_libmodem-nrf
- ✅ test-fw-nrfconnect-nrf-iot_serial_lte_modem - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-nrf-iot_zephyr_lwm2m - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-nrf-iot_samples - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-nrf-iot_lwm2m - Skipped: Job was skipped as it succeeded in a previous run
- ✅ doc-internal - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-nrf-iot_thingy91 - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-nrf_crypto - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-proprietary_esb - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-rpc - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-rs - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-fem - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-tfm - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-thread - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-zigbee - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-sdk-find-my - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-nrf-iot_mosh - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-nrf-iot_positioning - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-sdk-sidewalk - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-sdk-wifi - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-low-level - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-nrf-iot_nrf_provisioning - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-sdk-pmic-samples - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-sdk-mcuboot - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-sdk-dfu - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-ps - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-secdom-samples-public - Skipped: Job was skipped as it succeeded in a previous run

Note: This message is automatically posted and updated by the CI

cmake/sysbuild/sdp.cmake

magp-nordic · 2024-10-03T18:25:18Z

Now based on #17256 (first commit)
Please, do not review yet, needs some alignment after #16592 was merged.

NordicBuilder · 2024-10-03T18:39:59Z

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

jaz1-nordic

nitpicks. Additionally please resolve complaints from CI.

snippets/emulated-gpio/icbmsg/snippet.yml

snippets/emulated-gpio/icbmsg/boards/nrf54l15dk_nrf54l15_cpuapp.conf

magp-nordic · 2024-10-07T15:21:55Z

Rebased on main, ready for review

applications/sdp/gpio/boards/nrf54l15dk_nrf54l15_cpuflpr_icbmsg.overlay

snippets/emulated-gpio/icbmsg/emulated-gpio.overlay

Snippets usage to be clarified in other forum/PR.

hubertmis · 2024-10-22T05:09:45Z

Could you clarify, what is the reason to use icbmsg in egpio?

masz-nordic · 2024-10-22T09:13:59Z

To showcase that this backend can be used in SDP.

hubertmis · 2024-10-22T09:36:43Z

To showcase that this backend can be used in SDP.

Do we expect this backend to be useful in other SDPs?

masz-nordic · 2024-10-22T09:39:58Z

Do we expect this backend to be useful in other SDPs?

Potentially, yes.

Move division of SRAM to backends' overlays so that it would be possible to have different FLPR SRAM size for each backend. Signed-off-by: Magdalena Pastula <[email protected]>

Add icbmsg as a possible backend for eGPIO. Signed-off-by: Magdalena Pastula <[email protected]>

Add icbmsg as possible backend for eGPIO. Signed-off-by: Magdalena Pastula <[email protected]>

Add option of ICBMSG as a backend for eGPIO. Signed-off-by: Magdalena Pastula <[email protected]>

Add eGPIO testcase with icbmsg backend. Signed-off-by: Magdalena Pastula <[email protected]>

Add test case for eGPIO using icbmsg backend. Signed-off-by: Magdalena Pastula <[email protected]>

When using `k_busy_wait`, icbmsg fails to handle messaging on APP side. Signed-off-by: Marcin Szymczyk <[email protected]>

masz-nordic · 2024-10-22T09:54:57Z

Just a rebase

applications/sdp/gpio/src/backend/backend.h

magp-nordic requested a review from jaz1-nordic September 13, 2024 15:53

magp-nordic requested review from a team, anangl, carlescufi, masz-nordic, nordicjm and tejlmand as code owners September 13, 2024 15:53

github-actions bot added manifest changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Sep 13, 2024

NordicBuilder added manifest-zephyr DNM labels Sep 13, 2024

nordicjm reviewed Sep 16, 2024

View reviewed changes

cmake/sysbuild/sdp.cmake Outdated Show resolved Hide resolved

cmake/sysbuild/sdp.cmake Outdated Show resolved Hide resolved

cmake/sysbuild/sdp.cmake Outdated Show resolved Hide resolved

cmake/sysbuild/sdp.cmake Outdated Show resolved Hide resolved

nordicjm mentioned this pull request Sep 16, 2024

add mbox backend for eGPIO #16592

Merged

magp-nordic force-pushed the NRFX-6118-add-icbmsg-to-egpio branch from 7323ad8 to 7ff5196 Compare October 3, 2024 18:24

magp-nordic requested review from a team as code owners October 3, 2024 18:24

magp-nordic mentioned this pull request Oct 3, 2024

Nrfx 6118 add icbmsg to egpio nrfconnect/sdk-zephyr#2025

Closed

jaz1-nordic reviewed Oct 4, 2024

View reviewed changes

snippets/emulated-gpio/icbmsg/snippet.yml Outdated Show resolved Hide resolved

snippets/emulated-gpio/icbmsg/boards/nrf54l15dk_nrf54l15_cpuapp.conf Outdated Show resolved Hide resolved

magp-nordic force-pushed the NRFX-6118-add-icbmsg-to-egpio branch 2 times, most recently from 6ef0952 to 5cc9ee1 Compare October 7, 2024 11:46

github-actions bot removed the manifest label Oct 7, 2024

magp-nordic force-pushed the NRFX-6118-add-icbmsg-to-egpio branch 2 times, most recently from 8a96d41 to 7796285 Compare October 7, 2024 15:21

magp-nordic requested a review from nordicjm October 7, 2024 15:21

magp-nordic requested review from jaz1-nordic and masz-nordic October 18, 2024 15:12

masz-nordic mentioned this pull request Oct 18, 2024

snippets: emulated-gpio: align RRAM #18013

Merged

shanthanordic requested review from miha-nordic and removed request for a team October 21, 2024 09:48

masz-nordic approved these changes Oct 21, 2024

View reviewed changes

applications/sdp/gpio/boards/nrf54l15dk_nrf54l15_cpuflpr_icbmsg.overlay Outdated Show resolved Hide resolved

snippets/emulated-gpio/icbmsg/emulated-gpio.overlay Outdated Show resolved Hide resolved

jaz1-nordic approved these changes Oct 21, 2024

View reviewed changes

carlescufi approved these changes Oct 22, 2024

View reviewed changes

magp-nordic and others added 9 commits October 22, 2024 11:54

applications: sdp: gpio: move SRAM partitions to backend overlays

b060d4a

Move division of SRAM to backends' overlays so that it would be possible to have different FLPR SRAM size for each backend. Signed-off-by: Magdalena Pastula <[email protected]>

application: sdp: add icbmsg backend for eGPIO

5d47510

Add icbmsg as a possible backend for eGPIO. Signed-off-by: Magdalena Pastula <[email protected]>

drivers: gpio: add icbmsg backend to eGPIO

533b732

Add icbmsg as possible backend for eGPIO. Signed-off-by: Magdalena Pastula <[email protected]>

cmake: sysbuild: add icbmsg backend to eGPIO

0b050df

Add icbmsg as possible backend for eGPIO. Signed-off-by: Magdalena Pastula <[email protected]>

snippets: emulated-gpio: add icbmsg backend for eGPIO

f047771

Add icbmsg as possible backend for eGPIO. Signed-off-by: Magdalena Pastula <[email protected]>

sysbuild: add icbmsg as possible eGPIO backend

2b59517

Add option of ICBMSG as a backend for eGPIO. Signed-off-by: Magdalena Pastula <[email protected]>

samples: basic: blinky: add eGPIO testcase

4267e9b

Add eGPIO testcase with icbmsg backend. Signed-off-by: Magdalena Pastula <[email protected]>

tests: drivers: gpio: add test case for icbmsg backend

4b98781

Add test case for eGPIO using icbmsg backend. Signed-off-by: Magdalena Pastula <[email protected]>

tests: drivers: gpio: egpio_basic_api: switch to k_sleep

1c37e62

When using `k_busy_wait`, icbmsg fails to handle messaging on APP side. Signed-off-by: Marcin Szymczyk <[email protected]>

masz-nordic force-pushed the NRFX-6118-add-icbmsg-to-egpio branch from 730dafa to 1c37e62 Compare October 22, 2024 09:54

miha-nordic approved these changes Oct 22, 2024

View reviewed changes

anangl reviewed Oct 22, 2024

View reviewed changes

applications/sdp/gpio/src/backend/backend.h Show resolved Hide resolved

anangl approved these changes Oct 22, 2024

View reviewed changes

rlubos removed the manifest-zephyr label Oct 22, 2024

rlubos merged commit 72fac47 into nrfconnect:main Oct 22, 2024
14 checks passed

magp-nordic deleted the NRFX-6118-add-icbmsg-to-egpio branch October 23, 2024 07:34

Nrfx 6118 add icbmsg to egpio #17321

Nrfx 6118 add icbmsg to egpio #17321

Uh oh!

Conversation

magp-nordic commented Sep 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

NordicBuilder commented Sep 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

NordicBuilder commented Sep 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CI Information

Inputs:

Sources:

Github labels

Outputs:

Toolchain

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

magp-nordic commented Oct 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

NordicBuilder commented Oct 3, 2024

Uh oh!

jaz1-nordic left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

magp-nordic commented Oct 7, 2024

Uh oh!

Uh oh!

Uh oh!

hubertmis commented Oct 22, 2024

Uh oh!

masz-nordic commented Oct 22, 2024

Uh oh!

hubertmis commented Oct 22, 2024

Uh oh!

masz-nordic commented Oct 22, 2024

Uh oh!

masz-nordic commented Oct 22, 2024

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

magp-nordic commented Sep 13, 2024 •

edited

Loading

NordicBuilder commented Sep 13, 2024 •

edited

Loading

NordicBuilder commented Sep 13, 2024 •

edited

Loading

magp-nordic commented Oct 3, 2024 •

edited

Loading