sysbuild: Add compression options for MCUboot #17330

nordicjm · 2024-09-16T12:36:12Z

manifest: Update sdk-mcuboot

Pulls in changes for image decompression support



sysbuild: Add compression options for MCUboot

Adds an option which will enable compressed image support in
MCUboot



tests: nrf_compress: decompression: Add mcuboot_update test

Adds a test which ensures compressed update image support works
in MCUbot

NordicBuilder · 2024-09-16T12:36:43Z

The following west manifest projects have been modified in this Pull Request:

Name	Old Revision	New Revision	Diff
mcuboot	nrfconnect/sdk-mcuboot@`22adc04`	nrfconnect/sdk-mcuboot@`94212b4` (main)	nrfconnect/[email protected]

Note: This message is automatically posted and updated by the Manifest GitHub Action.

NordicBuilder · 2024-09-16T12:50:23Z

CI Information

^{To view the history of this post, clich the 'edited' button above}
Build number: 27

Inputs:

Sources:

sdk-nrf: PR head: 99c91ae20d1beafdbd057b7e55710b23b9a7e6d3
mcuboot: PR head: 94212b4e3853b7b09acf0e2e1ec2b895bbbb2948

more details

sdk-nrf:

PR head: 99c91ae20d1beafdbd057b7e55710b23b9a7e6d3
merge base: c2e2b2e1ef91e8d7b3d17434fa04212d9fcada2d
target head (main): 4a34c9083a88920d3298f26a0e3058454c1b510d
Diff

mcuboot:

PR head: 94212b4e3853b7b09acf0e2e1ec2b895bbbb2948
merge base: 22adc04fc4b35a6ee477675c8a33e038a98258de
Diff

Github labels

Enabled	Name	Description
	ci-disabled	Disable the ci execution
	ci-all-test	Run all of ci, no test spec filtering will be done
	ci-force-downstream	Force execution of downstream even if twister fails
	ci-run-twister	Force run twister
	ci-run-zephyr-twister	Force run zephyr twister

List of changed files detected by CI (37)

bootloader
│  ├── mcuboot
│  │  ├── boot
│  │  │  ├── bootutil
│  │  │  │  ├── src
│  │  │  │  │  ├── image_validate.c
│  │  │  │  │  │ swap_scratch.c
│  │  │  ├── zephyr
│  │  │  │  │ decompression.c
│  │  ├── scripts
│  │  │  ├── imgtool
│  │  │  │  ├── image.py
│  │  │  │  │ main.py
cmake
│  ├── sysbuild
│  │  │ image_signing.cmake
samples
│  ├── nrf_compress
│  │  ├── mcuboot_update
│  │  │  ├── CMakeLists.txt
│  │  │  ├── prj.conf
│  │  │  ├── src
│  │  │  │  │ hook.c
│  │  │  ├── sysbuild.conf
│  │  │  ├── sysbuild
│  │  │  │  │ mcuboot.conf
│  │  │  │ testcase.yaml
subsys
│  ├── bootloader
│  │  │ Kconfig
│  ├── partition_manager
│  │  │ Kconfig
sysbuild
│  ├── CMakeLists.txt
│  │ Kconfig.mcuboot
tests
│  ├── subsys
│  │  ├── nrf_compress
│  │  │  ├── decompression
│  │  │  │  ├── mcuboot_update
│  │  │  │  │  ├── CMakeLists.txt
│  │  │  │  │  ├── Kconfig
│  │  │  │  │  ├── app.overlay
│  │  │  │  │  ├── compressed_app
│  │  │  │  │  │  ├── CMakeLists.txt
│  │  │  │  │  │  ├── prj.conf
│  │  │  │  │  │  ├── src
│  │  │  │  │  │  │  │ main.c
│  │  │  │  │  ├── modified_signing.cmake
│  │  │  │  │  ├── pm_static_nrf52840dk_nrf52840.yml
│  │  │  │  │  ├── pm_static_nrf5340dk_nrf5340_cpuapp.yml
│  │  │  │  │  ├── pm_static_nrf54l15dk_nrf54l15_cpuapp.yml
│  │  │  │  │  ├── prj.conf
│  │  │  │  │  ├── src
│  │  │  │  │  │  │ main.c
│  │  │  │  │  ├── sysbuild.cmake
│  │  │  │  │  ├── sysbuild.conf
│  │  │  │  │  ├── sysbuild
│  │  │  │  │  │  ├── mcuboot
│  │  │  │  │  │  │  ├── app.overlay
│  │  │  │  │  │  │  ├── boards
│  │  │  │  │  │  │  │  ├── nrf52840dk_nrf52840.conf
│  │  │  │  │  │  │  │  ├── nrf54l15dk_nrf54l15_cpuapp.conf
│  │  │  │  │  │  │  │  │ nrf54l15dk_nrf54l15_cpuapp.overlay
│  │  │  │  │  │  │  │ prj.conf
│  │  │  │  │  │ testcase.yaml
west.yml

Outputs:

Toolchain

Version: 6c44240e03
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:6c44240e03_81ed5a52d6

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

◻️ Toolchain - Skipped: existing toolchain is used
✅ Build twister - Skipped: Skipping Build & Test as it succeeded in a previous run: 25
❌ Integration tests
- ✅ test-sdk-audio - Skipped: Job was skipped as it succeeded in a previous run
- ✅ desktop52_verification - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-boot - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-apps - Skipped: Job was skipped as it succeeded in a previous run
- ❌ test_ble_nrf_config
- ✅ test-fw-nrfconnect-ble_mesh - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-ble_samples - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-chip - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-nfc - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-nrf-iot_cloud - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-nrf-iot_libmodem-nrf - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-nrf-iot_serial_lte_modem - Skipped: Job was skipped as it succeeded in a previous run
- ❌ test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
- ✅ test-fw-nrfconnect-nrf-iot_samples - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-nrf-iot_lwm2m - Skipped: Job was skipped as it succeeded in a previous run
- ✅ doc-internal - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-nrf-iot_thingy91 - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-nrf_crypto - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-proprietary_esb - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-rpc - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-rs - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-fem - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-tfm - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-thread
- ✅ test-fw-nrfconnect-zigbee - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-sdk-find-my - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-nrf-iot_mosh - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-nrf-iot_positioning - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-sdk-sidewalk - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-sdk-wifi - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-low-level - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-nrf-iot_nrf_provisioning - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-sdk-pmic-samples - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-sdk-mcuboot - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-sdk-dfu - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-ps - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-secdom-samples-public - Skipped: Job was skipped as it succeeded in a previous run
- ⚠️ test-fw-nrfconnect-fw-update

Note: This message is automatically posted and updated by the CI

NordicBuilder · 2024-09-16T12:59:55Z

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

nvlsianpu

just a few nits. Now I see why you need intel-hex output from imgtool.py

nvlsianpu · 2024-09-25T06:30:19Z

samples/nrf_compress/mcuboot_update/src/main.c

not a main content of this sample in this file - expect main(). rename?

nvlsianpu · 2024-09-25T06:32:49Z

samples/nrf_compress/mcuboot_update/src/main.c

comment in the code for explaining what is it doing would be helpful once someone will look at this in few months.

nvlsianpu · 2024-09-25T06:33:47Z

samples/nrf_compress/mcuboot_update/src/main.c

what does this SYS_INIT?

nvlsianpu · 2024-09-25T06:39:53Z

...mpress/decompression/mcuboot_update/sysbuild/mcuboot/boards/nrf54l15pdk_nrf54l15_cpuapp.conf

Suggested change

CONFIG_NORDIC_QSPI_NOR=n

CONFIG_NORDIC_SPI_NOR=n

nRF54l15 hasn't QSPI.

NordicBuilder · 2024-10-07T08:47:35Z

Memory footprint analysis revealed the following potential issues

sample.matter.template.debug[nrf7002dk/nrf5340/cpuapp]: High RAM usage: 394774[B] - link (cc: @kkasperczyk-no @ArekBalysNordic @markaj-nordic)

Note: This message is automatically posted and updated by the CI (latest/sdk-nrf/PR-17330/25)

Adds an option that will utilise the whole SRAM size as specified by a single image, and enables it for nrf54l15 when using decompression in MCUboot Signed-off-by: Jamie McCrae <[email protected]>

Pulls in changes for image decompression support Signed-off-by: Jamie McCrae <[email protected]>

Adds an option which will enable compressed image support in MCUboot Signed-off-by: Jamie McCrae <[email protected]>

Adds a test which ensures compressed update image support works in MCUbot Signed-off-by: Jamie McCrae <[email protected]>

Adds a sample which shows usage of compressed image updates Signed-off-by: Jamie McCrae <[email protected]>

nordicjm · 2024-10-07T13:32:27Z

@carlescufi @tejlmand can you review please?

github-actions bot added manifest changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Sep 16, 2024

NordicBuilder added manifest-mcuboot DNM labels Sep 16, 2024

nordicjm force-pushed the mcubootcompresstest branch 5 times, most recently from 2b69b1a to 9df875d Compare September 20, 2024 12:11

nordicjm marked this pull request as ready for review September 20, 2024 12:11

nordicjm requested a review from a team as a code owner September 20, 2024 12:11

nordicjm requested a review from a team September 20, 2024 12:11

nordicjm requested a review from a team as a code owner September 20, 2024 12:11

nordicjm force-pushed the mcubootcompresstest branch 3 times, most recently from 861cdf9 to 1481c87 Compare September 24, 2024 15:03

nvlsianpu requested changes Sep 25, 2024

View reviewed changes

nordicjm force-pushed the mcubootcompresstest branch 7 times, most recently from 74087b4 to 477181a Compare October 2, 2024 10:55

NordicBuilder added the manifest-zephyr label Oct 2, 2024

nordicjm force-pushed the mcubootcompresstest branch from 477181a to 2ad8413 Compare October 2, 2024 13:07

nvlsianpu approved these changes Oct 3, 2024

View reviewed changes

nordicjm force-pushed the mcubootcompresstest branch 2 times, most recently from d0a03a9 to 02ff743 Compare October 4, 2024 08:59

NordicBuilder removed the DNM label Oct 4, 2024

nordicjm mentioned this pull request Oct 7, 2024

imgtool compression #17656

Closed

nordicjm force-pushed the mcubootcompresstest branch from 02ff743 to 8091b56 Compare October 7, 2024 07:43

NordicBuilder added the DNM label Oct 7, 2024

nordicjm force-pushed the mcubootcompresstest branch 4 times, most recently from 03fe100 to 9ba00f3 Compare October 7, 2024 11:18

nordicjm added 5 commits October 7, 2024 14:28

partition_manager: kconfig: Add option to use all SRAM in PM

2c53413

Adds an option that will utilise the whole SRAM size as specified by a single image, and enables it for nrf54l15 when using decompression in MCUboot Signed-off-by: Jamie McCrae <[email protected]>

manifest: Update sdk-mcuboot

53d1781

Pulls in changes for image decompression support Signed-off-by: Jamie McCrae <[email protected]>

sysbuild: Add compression options for MCUboot

f6bb42b

Adds an option which will enable compressed image support in MCUboot Signed-off-by: Jamie McCrae <[email protected]>

tests: nrf_compress: decompression: Add mcuboot_update test

58d8c15

Adds a test which ensures compressed update image support works in MCUbot Signed-off-by: Jamie McCrae <[email protected]>

samples: nrf_compress: Add mcuboot_update sample

99c91ae

Adds a sample which shows usage of compressed image updates Signed-off-by: Jamie McCrae <[email protected]>

nordicjm force-pushed the mcubootcompresstest branch from 9ba00f3 to 99c91ae Compare October 7, 2024 13:30

NordicBuilder removed the DNM label Oct 7, 2024

nordicjm requested a review from de-nordic October 8, 2024 08:48

nordicjm removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Oct 8, 2024

nordicjm requested a review from gchwier October 8, 2024 08:51

tejlmand approved these changes Oct 8, 2024

View reviewed changes

de-nordic approved these changes Oct 8, 2024

View reviewed changes

carlescufi approved these changes Oct 8, 2024

View reviewed changes

rlubos merged commit 5df732e into nrfconnect:main Oct 9, 2024
13 of 15 checks passed

nordicjm deleted the mcubootcompresstest branch November 6, 2024 07:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

sysbuild: Add compression options for MCUboot #17330

sysbuild: Add compression options for MCUboot #17330

Uh oh!

nordicjm commented Sep 16, 2024

Uh oh!

NordicBuilder commented Sep 16, 2024 •

edited

Loading

Uh oh!

NordicBuilder commented Sep 16, 2024 •

edited

Loading

Uh oh!

NordicBuilder commented Sep 16, 2024

Uh oh!

nvlsianpu left a comment

Uh oh!

nvlsianpu Sep 25, 2024

Uh oh!

nvlsianpu Sep 25, 2024

Uh oh!

nvlsianpu Sep 25, 2024

Uh oh!

nvlsianpu Sep 25, 2024

Uh oh!

NordicBuilder commented Oct 7, 2024 •

edited

Loading

Uh oh!

nordicjm commented Oct 7, 2024

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Uh oh!

sysbuild: Add compression options for MCUboot #17330

sysbuild: Add compression options for MCUboot #17330

Uh oh!

Conversation

nordicjm commented Sep 16, 2024

Uh oh!

NordicBuilder commented Sep 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

NordicBuilder commented Sep 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CI Information

Inputs:

Sources:

Github labels

Outputs:

Toolchain

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

Uh oh!

NordicBuilder commented Sep 16, 2024

Uh oh!

nvlsianpu left a comment

Choose a reason for hiding this comment

Uh oh!

nvlsianpu Sep 25, 2024

Choose a reason for hiding this comment

Uh oh!

nvlsianpu Sep 25, 2024

Choose a reason for hiding this comment

Uh oh!

nvlsianpu Sep 25, 2024

Choose a reason for hiding this comment

Uh oh!

nvlsianpu Sep 25, 2024

Choose a reason for hiding this comment

Uh oh!

NordicBuilder commented Oct 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Memory footprint analysis revealed the following potential issues

Uh oh!

nordicjm commented Oct 7, 2024

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

NordicBuilder commented Sep 16, 2024 •

edited

Loading

NordicBuilder commented Sep 16, 2024 •

edited

Loading

NordicBuilder commented Oct 7, 2024 •

edited

Loading