manifest: Update nrf_modem library and add nRF92 support #17475

anhmolt · 2024-09-25T08:38:23Z

See CHANGELOG file in nrfxlib for details about library features and changes.

NordicBuilder · 2024-09-25T08:39:04Z

The following west manifest projects have been modified in this Pull Request:

Name	Old Revision	New Revision	Diff
nrfxlib	nrfconnect/sdk-nrfxlib@`823dc44`	nrfconnect/sdk-nrfxlib@`5d75e40` (main)	nrfconnect/[email protected]

Note: This message is automatically posted and updated by the Manifest GitHub Action.

NordicBuilder · 2024-09-25T09:03:47Z

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

lib/nrf_modem_lib/nrf_modem_os_rpc.c

NordicBuilder · 2024-09-26T13:46:13Z

CI Information

^{To view the history of this post, clich the 'edited' button above}
Build number: 36

Inputs:

Sources:

sdk-nrf: PR head: 90b2ec0bef6a348649792534f9cc9da0d8394f88
nrfxlib: PR head: 5d75e4047488d4056fe34f8343743a5959a82508

more details

sdk-nrf:

PR head: 90b2ec0bef6a348649792534f9cc9da0d8394f88
merge base: 282622bc9f5bf0454cabd41449b338d5a3cde34d
target head (main): 282622bc9f5bf0454cabd41449b338d5a3cde34d
Diff

nrfxlib:

PR head: 5d75e4047488d4056fe34f8343743a5959a82508
merge base: 823dc44860702fcad14b1b12c32c99d8fa11be44
Diff

Github labels

Enabled	Name	Description
	ci-disabled	Disable the ci execution
	ci-all-test	Run all of ci, no test spec filtering will be done
	ci-force-downstream	Force execution of downstream even if twister fails
	ci-run-twister	Force run twister
	ci-run-zephyr-twister	Force run zephyr twister

List of changed files detected by CI (59)

applications
│  ├── serial_lte_modem
│  │  ├── doc
│  │  │  │ SOCKET_AT_commands.rst
│  │  ├── src
│  │  │  ├── slm_at_socket.c
│  │  │  ├── slm_sockopt.h
│  │  │  │ slm_trap_macros.h
doc
│  ├── nrf
│  │  ├── releases_and_maturity
│  │  │  ├── releases
│  │  │  │  │ release-notes-changelog.rst
lib
│  ├── gcf_sms
│  │  │ gcf_sms.c
│  ├── modem_attest_token
│  │  │ modem_attest_token.c
│  ├── nrf_modem_lib
│  │  ├── CMakeLists.txt
│  │  ├── Kconfig
│  │  ├── Kconfig.modemlib
│  │  ├── nrf9x_sockets.c
│  │  ├── nrf_modem_lib.c
│  │  ├── nrf_modem_os.c
│  │  ├── nrf_modem_os_rpc.c
│  │  │ sanity.c
nrfxlib
│  ├── nrf_modem
│  │  ├── CMakeLists.txt
│  │  ├── Kconfig
│  │  ├── doc
│  │  │  ├── CHANGELOG.rst
│  │  │  ├── api.rst
│  │  │  ├── sockets
│  │  │  │  │ socket_options_func.rst
│  │  ├── include
│  │  │  ├── nrf_modem_at.h
│  │  │  ├── nrf_modem_dect_phy.h
│  │  │  ├── nrf_modem_os.h
│  │  │  ├── nrf_modem_os_rpc.h
│  │  │  ├── nrf_modem_toolchain.h
│  │  │  ├── nrf_modem_trace.h
│  │  │  │ nrf_socket.h
│  │  ├── lib
│  │  │  ├── cellular
│  │  │  │  ├── nrf9120
│  │  │  │  │  ├── hard-float
│  │  │  │  │  │  ├── libmodem.a
│  │  │  │  │  │  │ libmodem_log.a
│  │  │  │  │  ├── soft-float
│  │  │  │  │  │  ├── libmodem.a
│  │  │  │  │  │  │ libmodem_log.a
│  │  │  │  ├── nrf9160
│  │  │  │  │  ├── hard-float
│  │  │  │  │  │  ├── libmodem.a
│  │  │  │  │  │  │ libmodem_log.a
│  │  │  │  │  ├── soft-float
│  │  │  │  │  │  ├── libmodem.a
│  │  │  │  │  │  │ libmodem_log.a
│  │  │  │  ├── nrf9230
│  │  │  │  │  ├── hard-float
│  │  │  │  │  │  ├── libmodem.a
│  │  │  │  │  │  │ libmodem_log.a
│  │  │  │  │  ├── soft-float
│  │  │  │  │  │  ├── libmodem.a
│  │  │  │  │  │  │ libmodem_log.a
│  │  │  ├── dect_phy
│  │  │  │  ├── nrf9120
│  │  │  │  │  ├── hard-float
│  │  │  │  │  │  ├── libmodem.a
│  │  │  │  │  │  │ libmodem_log.a
│  │  │  │  │  ├── soft-float
│  │  │  │  │  │  ├── libmodem.a
│  │  │  │  │  │  │ libmodem_log.a
samples
│  ├── cellular
│  │  ├── modem_shell
│  │  │  ├── src
│  │  │  │  ├── drivers
│  │  │  │  │  │ nrf91_non_offloaded_dev.c
│  ├── dect
│  │  ├── dect_phy
│  │  │  ├── dect_shell
│  │  │  │  ├── src
│  │  │  │  │  ├── dect
│  │  │  │  │  │  ├── dect_phy_ctrl.c
│  │  │  │  │  │  ├── perf
│  │  │  │  │  │  │  │ dect_phy_perf.c
│  │  │  │  │  │  ├── ping
│  │  │  │  │  │  │  │ dect_phy_ping.c
│  │  │  │  │  │  ├── rf_tool
│  │  │  │  │  │  │  │ dect_phy_rf_tool.c
│  │  │  ├── hello_dect
│  │  │  │  ├── src
│  │  │  │  │  │ main.c
tests
│  ├── lib
│  │  ├── date_time
│  │  │  │ CMakeLists.txt
│  │  ├── location
│  │  │  │ CMakeLists.txt
│  │  ├── lte_lc
│  │  │  │ CMakeLists.txt
│  │  ├── lte_lc_api
│  │  │  │ CMakeLists.txt
│  │  ├── modem_jwt
│  │  │  │ CMakeLists.txt
│  │  ├── nrf_modem_lib
│  │  │  ├── lte_net_if
│  │  │  │  ├── CMakeLists.txt
│  │  │  │  │ testcase.yaml
│  │  │  ├── nrf9x_sockets
│  │  │  │  │ testcase.yaml
│  │  ├── sms
│  │  │  │ CMakeLists.txt
west.yml

Outputs:

Toolchain

Version: 3dd8985b56
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:3dd8985b56_81ed5a52d6

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

◻️ Toolchain - Skipped: existing toolchain is used
✅ Build twister
- sdk-nrf test count: 393
✅ Integration tests
- ✅ test-fw-nrfconnect-nrf-iot_cloud
- ✅ test-fw-nrfconnect-nrf-iot_libmodem-nrf
- ✅ test-fw-nrfconnect-nrf-iot_serial_lte_modem
- ✅ test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
- ✅ test-fw-nrfconnect-nrf-iot_samples
- ✅ test-fw-nrfconnect-nrf-iot_lwm2m
- ✅ test-fw-nrfconnect-nrf-iot_mosh
- ✅ test-fw-nrfconnect-nrf-iot_positioning

Disabled integration tests

- desktop52_verification
- doc-internal
- test_ble_nrf_config
- test-fw-nrfconnect-apps
- test-fw-nrfconnect-ble_mesh
- test-fw-nrfconnect-ble_samples
- test-fw-nrfconnect-boot
- test-fw-nrfconnect-chip
- test-fw-nrfconnect-fem
- test-fw-nrfconnect-nfc
- test-fw-nrfconnect-nrf-iot_nrf_provisioning
- test-fw-nrfconnect-nrf-iot_thingy91
- test-fw-nrfconnect-nrf_crypto
- test-fw-nrfconnect-proprietary_esb
- test-fw-nrfconnect-ps
- test-fw-nrfconnect-rpc
- test-fw-nrfconnect-rs
- test-fw-nrfconnect-tfm
- test-fw-nrfconnect-thread
- test-fw-nrfconnect-zigbee
- test-low-level
- test-sdk-audio
- test-sdk-dfu
- test-sdk-find-my
- test-sdk-mcuboot
- test-sdk-pmic-samples
- test-sdk-sidewalk
- test-sdk-wifi
- test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

eivindj-nordic · 2024-10-01T11:15:51Z

lib/nrf_modem_lib/nrf_modem_lib.c

Could we use DT for size as well and get rid of the KConfig values for nRF92?

No, not currently. It must be set to the value of CONFIG_NRF_MODEM_SHMEM_CTRL_SIZE exported by nrf_modem. This is not in the devicetree. Let's see if we can improve this in some later work.

lib/nrf_modem_lib/nrf_modem_os.c

Fix mocking of AT functions before updating nrf_modem with format checking on AT functions. Signed-off-by: Andreas Moltumyr <[email protected]>

Update tests to run with the native_sim board instead of the deprecated native_posix board. Signed-off-by: Andreas Moltumyr <[email protected]>

Correctly pass arguments to nrf_modem_at_scanf for ATTESTTOKEN AT command. Signed-off-by: Andreas Moltumyr <[email protected]>

Correctly pass arguments to nrf_modem_at functions. Remove unnecessary \0. Signed-off-by: Andreas Moltumyr <[email protected]>

Correctly pass arguments to nrf_modem_at_cmd() functions. Remove unnecessary stack variables. Signed-off-by: Andreas Moltumyr <[email protected]>

The nrf_modem library will start to checks the format of scanf and printf variable arguments for its AT functions. As a result, redefining the functions with an empty/void argument list will no longer work going forward. Solution: Forward the argument declarations by using __VA_ARGS__. Rename the new 'only declared' functions so they have unique names and no type conflicts. Signed-off-by: Andreas Moltumyr <[email protected]>

Pull in latest nrf_modem. For a detailed list of changes, see its CHANGELOG file. Signed-off-by: Andreas Moltumyr <[email protected]>

Updates due to recent libmodem api changes for adding stf_cover_seq_control callback. Signed-off-by: Jani Hirsimäki <[email protected]>

Updates due to recent libmodem api changes for adding stf_cover_seq_control callback. Signed-off-by: Andreas Moltumyr <[email protected]>

The nrf_modem library function nrf_getaddrinfo now supports concurrent handling of requests. Therefore, the mutex in the offloading layer is no longer required. Remove it. Signed-off-by: Andreas Moltumyr <[email protected]>

Add support for running nrf_modem library on nRF92 application CPU. Signed-off-by: Andreas Moltumyr <[email protected]>

Add support for new socket option NRF_SO_IPV6_DELAYED_ADDR_REFRESH for delaying IPv6 address refresh when using IPv6. Signed-off-by: Andreas Moltumyr <[email protected]>

Add new socket option SO_IPV6_DELAYED_ADDR_REFRESH for delaying IPv6 address refresh when using IPv6. Signed-off-by: Andreas Moltumyr <[email protected]>

anhmolt requested review from a team, MirkoCovizzi and lemrey as code owners September 25, 2024 08:38

github-actions bot added doc-required PR must not be merged without tech writer approval. manifest changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Sep 25, 2024

NordicBuilder added manifest-nrfxlib manifest-zephyr DNM labels Sep 25, 2024

MirkoCovizzi reviewed Sep 25, 2024

View reviewed changes

lib/nrf_modem_lib/nrf_modem_os_rpc.c Outdated Show resolved Hide resolved

anhmolt force-pushed the nrf_modem-update-lib-and-add-nrf92 branch from 13a1f95 to b3d3f3e Compare September 26, 2024 13:24

anhmolt requested review from jayteemo, jhirsi, tokangas and trantanen as code owners September 26, 2024 13:24

eivindj-nordic reviewed Oct 1, 2024

View reviewed changes

lemrey approved these changes Oct 1, 2024

View reviewed changes

divipillai approved these changes Oct 1, 2024

View reviewed changes

anhmolt force-pushed the nrf_modem-update-lib-and-add-nrf92 branch 2 times, most recently from 1f53cd4 to 9e76bd8 Compare October 1, 2024 14:28

anhmolt removed the manifest-zephyr label Oct 2, 2024

SeppoTakalo approved these changes Oct 2, 2024

View reviewed changes

anhmolt force-pushed the nrf_modem-update-lib-and-add-nrf92 branch 2 times, most recently from b2309c8 to 449652c Compare October 10, 2024 08:58

trantanen approved these changes Oct 10, 2024

View reviewed changes

jhirsi mentioned this pull request Oct 10, 2024

samples: dect: dect_phy: dect_shell: updates due to recent libmodem api changes #17812

Closed

anhmolt force-pushed the nrf_modem-update-lib-and-add-nrf92 branch from 449652c to 06ce5ee Compare October 10, 2024 14:21

github-actions bot added the manifest label Oct 10, 2024

anhmolt added CI-all-test Run All integration tests and removed manifest labels Oct 10, 2024

NordicBuilder added manifest DNM labels Oct 10, 2024

jhirsi approved these changes Oct 11, 2024

View reviewed changes

anhmolt removed the CI-all-test Run All integration tests label Oct 11, 2024

anhmolt force-pushed the nrf_modem-update-lib-and-add-nrf92 branch from 06ce5ee to 72205e4 Compare October 11, 2024 11:48

anhmolt and others added 13 commits October 14, 2024 09:30

tests: nrf_modem_lib: fix tests before updating nrf_modem

f437ae7

Fix mocking of AT functions before updating nrf_modem with format checking on AT functions. Signed-off-by: Andreas Moltumyr <[email protected]>

tests: nrf_modem_lib: switch from native_posix board to native_sim

7b7dee4

Update tests to run with the native_sim board instead of the deprecated native_posix board. Signed-off-by: Andreas Moltumyr <[email protected]>

lib: modem_attest_token: correct format usage

a7ce3ea

Correctly pass arguments to nrf_modem_at_scanf for ATTESTTOKEN AT command. Signed-off-by: Andreas Moltumyr <[email protected]>

lib: gcf_sms: correct format usage

38df85b

Correctly pass arguments to nrf_modem_at functions. Remove unnecessary \0. Signed-off-by: Andreas Moltumyr <[email protected]>

samples: modem_shell: correct format usage in nrf91_non_offloaded_dev

cf28221

Correctly pass arguments to nrf_modem_at_cmd() functions. Remove unnecessary stack variables. Signed-off-by: Andreas Moltumyr <[email protected]>

manifest: update sdk-nrfxlib revision with nrf_modem changes

fe9120a

Pull in latest nrf_modem. For a detailed list of changes, see its CHANGELOG file. Signed-off-by: Andreas Moltumyr <[email protected]>

samples: dect: dect_phy: dect_shell: updates due to libmodem api changes

2ce11e6

Updates due to recent libmodem api changes for adding stf_cover_seq_control callback. Signed-off-by: Jani Hirsimäki <[email protected]>

samples: dect: dect_phy: hello_dect: updates due to libmodem api changes

5d66e6f

Updates due to recent libmodem api changes for adding stf_cover_seq_control callback. Signed-off-by: Andreas Moltumyr <[email protected]>

nrf_modem_lib: nrf9x_sockets: remove mutex in getaddrinfo

2d06404

The nrf_modem library function nrf_getaddrinfo now supports concurrent handling of requests. Therefore, the mutex in the offloading layer is no longer required. Remove it. Signed-off-by: Andreas Moltumyr <[email protected]>

lib: nrf_modem_lib: nRF92 support

fcfd778

Add support for running nrf_modem library on nRF92 application CPU. Signed-off-by: Andreas Moltumyr <[email protected]>

lib: nrf_modem: add new sockopt NRF_SO_IPV6_DELAYED_ADDR_REFRESH

238f142

Add support for new socket option NRF_SO_IPV6_DELAYED_ADDR_REFRESH for delaying IPv6 address refresh when using IPv6. Signed-off-by: Andreas Moltumyr <[email protected]>

applications: serial_lte_modem: sockopt SO_IPV6_DELAYED_ADDR_REFRESH

90b2ec0

Add new socket option SO_IPV6_DELAYED_ADDR_REFRESH for delaying IPv6 address refresh when using IPv6. Signed-off-by: Andreas Moltumyr <[email protected]>

anhmolt force-pushed the nrf_modem-update-lib-and-add-nrf92 branch from 72205e4 to 90b2ec0 Compare October 14, 2024 07:32

NordicBuilder removed the DNM label Oct 14, 2024

eivindj-nordic approved these changes Oct 14, 2024

View reviewed changes

nordicjm merged commit 1df3f00 into nrfconnect:main Oct 14, 2024
13 of 14 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

manifest: Update nrf_modem library and add nRF92 support #17475

manifest: Update nrf_modem library and add nRF92 support #17475

Uh oh!

anhmolt commented Sep 25, 2024

Uh oh!

NordicBuilder commented Sep 25, 2024 •

edited

Loading

Uh oh!

NordicBuilder commented Sep 25, 2024

Uh oh!

Uh oh!

NordicBuilder commented Sep 26, 2024 •

edited

Loading

Uh oh!

eivindj-nordic Oct 1, 2024

Uh oh!

anhmolt Oct 2, 2024

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

14 participants

Uh oh!

manifest: Update nrf_modem library and add nRF92 support #17475

manifest: Update nrf_modem library and add nRF92 support #17475

Uh oh!

Conversation

anhmolt commented Sep 25, 2024

Uh oh!

NordicBuilder commented Sep 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

NordicBuilder commented Sep 25, 2024

Uh oh!

Uh oh!

NordicBuilder commented Sep 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CI Information

Inputs:

Sources:

Github labels

Outputs:

Toolchain

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

Uh oh!

eivindj-nordic Oct 1, 2024

Choose a reason for hiding this comment

Uh oh!

anhmolt Oct 2, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

14 participants

NordicBuilder commented Sep 25, 2024 •

edited

Loading

NordicBuilder commented Sep 26, 2024 •

edited

Loading