wifi: Add ext flash support for firmware patches #17652

krish2718 · 2024-10-05T14:58:28Z

Pull in prerequisites to add external flash support for nRF70 firmware patches

NordicBuilder · 2024-10-05T14:58:58Z

The following west manifest projects have been modified in this Pull Request:

Name	Old Revision	New Revision	Diff
zephyr	nrfconnect/sdk-zephyr@`3bedb2d`	nrfconnect/sdk-zephyr@`fe339b1` (main)	nrfconnect/[email protected]

Note: This message is automatically posted and updated by the Manifest GitHub Action.

NordicBuilder · 2024-10-05T15:01:10Z

CI Information

^{To view the history of this post, clich the 'edited' button above}
Build number: 22

Inputs:

Sources:

sdk-nrf: PR head: 39cfa1e7ba1242f6be35eda1b0addf1966b47b60
zephyr: PR head: fe339b14b3effd069458f5e4710f17cda8295229

more details

sdk-nrf:

PR head: 39cfa1e7ba1242f6be35eda1b0addf1966b47b60
merge base: 1a1c813962170a2b31328e3264e0bd9f5bfab468
target head (main): 1a1c813962170a2b31328e3264e0bd9f5bfab468
Diff

zephyr:

PR head: fe339b14b3effd069458f5e4710f17cda8295229
merge base: 3bedb2dfd9d68d08d5bf9405ce92c7e2bf11d4e7
Diff

Github labels

Enabled	Name	Description
	ci-disabled	Disable the ci execution
	ci-all-test	Run all of ci, no test spec filtering will be done
	ci-force-downstream	Force execution of downstream even if twister fails
	ci-run-twister	Force run twister
	ci-run-zephyr-twister	Force run zephyr twister

List of changed files detected by CI (20)

cmake
│  ├── sysbuild
│  │  │ nrf700x.cmake
samples
│  ├── matter
│  │  ├── lock
│  │  │  ├── boards
│  │  │  │  │ nrf7002dk_nrf5340_cpuapp.conf
scripts
│  │ quarantine.yaml
subsys
│  ├── net
│  │  ├── lib
│  │  │  ├── CMakeLists.txt
│  │  │  ├── Kconfig
│  │  │  ├── nrf70_fw_ext
│  │  │  │  ├── CMakeLists.txt
│  │  │  │  ├── Kconfig
│  │  │  │  ├── ext_fw_load.c
│  │  │  │  │ rpu_fw_patches.ld
sysbuild
│  │ CMakeLists.txt
west.yml
zephyr
│  ├── drivers
│  │  ├── usb
│  │  │  ├── udc
│  │  │  │  ├── Kconfig.dwc2
│  │  │  │  │ udc_dwc2_vendor_quirks.h
│  │  ├── wifi
│  │  │  ├── nrfwifi
│  │  │  │  ├── CMakeLists.txt
│  │  │  │  ├── Kconfig.nrfwifi
│  │  │  │  ├── rpu_fw_patches.ld
│  │  │  │  ├── src
│  │  │  │  │  │ fw_load.c
│  ├── include
│  │  ├── zephyr
│  │  │  ├── drivers
│  │  │  │  ├── usb
│  │  │  │  │  │ udc.h
│  ├── samples
│  │  ├── net
│  │  │  ├── wifi
│  │  │  │  ├── Kconfig.sysbuild
│  │  │  │  │ sample.yaml

Outputs:

Toolchain

Version: 3dd8985b56
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:3dd8985b56_912848a074

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

◻️ Toolchain - Skipped: existing toolchain is used
✅ Build twister
- sdk-nrf test count: 1378
- sdk-zephyr test count: 7160
✅ Integration tests
- ✅ test-fw-nrfconnect-boot
- ✅ test-fw-nrfconnect-chip
- ✅ test-fw-nrfconnect-nrf-iot_cloud
- ✅ test-fw-nrfconnect-nrf-iot_thingy91
- ✅ test-sdk-find-my
- ✅ test-fw-nrfconnect-nrf-iot_mosh
- ✅ test-fw-nrfconnect-nrf-iot_positioning
- ✅ test-low-level
- ✅ test-sdk-mcuboot
- ✅ test-sdk-dfu

Disabled integration tests

- desktop52_verification
- doc-internal
- test_ble_nrf_config
- test-fw-nrfconnect-apps
- test-fw-nrfconnect-ble_mesh
- test-fw-nrfconnect-ble_samples
- test-fw-nrfconnect-fem
- test-fw-nrfconnect-nfc
- test-fw-nrfconnect-nrf-iot_libmodem-nrf
- test-fw-nrfconnect-nrf-iot_lwm2m
- test-fw-nrfconnect-nrf-iot_nrf_provisioning
- test-fw-nrfconnect-nrf-iot_samples
- test-fw-nrfconnect-nrf-iot_serial_lte_modem
- test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
- test-fw-nrfconnect-nrf_crypto
- test-fw-nrfconnect-proprietary_esb
- test-fw-nrfconnect-ps
- test-fw-nrfconnect-rpc
- test-fw-nrfconnect-rs
- test-fw-nrfconnect-tfm
- test-fw-nrfconnect-thread
- test-fw-nrfconnect-zigbee
- test-sdk-audio
- test-sdk-pmic-samples
- test-sdk-sidewalk
- test-sdk-wifi
- test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

NordicBuilder · 2024-10-05T15:14:24Z

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

subsys/net/lib/Kconfig

subsys/net/lib/nrf70_fw_ext/CMakeLists.txt

sysbuild/CMakeLists.txt

subsys/net/lib/nrf70_fw_ext/ext_fw_load.c

samples/matter/lock/boards/nrf7002dk_nrf5340_cpuapp.conf

krish2718 · 2024-10-10T18:59:24Z

@rlubos for two of the twister failures, this nrfconnect/sdk-zephyr@4805f63 commit is needed, how should we proceed? But looks like that PR takes time to merge, should I just fix the Wi-Fi sample only in this PR?

krish2718 · 2024-10-10T19:29:04Z

@rlubos for two of the twister failures, this nrfconnect/sdk-zephyr@4805f63 commit is needed, how should we proceed? But looks like that PR takes time to merge, should I just fix the Wi-Fi sample only in this PR?

FYI nrfconnect/sdk-zephyr@77dd806 for CI to proceed, we can decide once CI is green.

rlubos · 2024-10-11T07:39:30Z

@krish2718 My PR nrfconnect/sdk-zephyr#2072 is practically ready, I'm not merging it yet intentionally because we have another large set of cherry-picks which has top priority now (#17721) and don't want disrupt that process. Will merge as soon as we'll done with that one.

subsys/net/lib/nrf70_fw_ext/CMakeLists.txt

subsys/net/lib/nrf70_fw_ext/ext_fw_load.c

cmake/sysbuild/nrf700x.cmake

krish2718 · 2024-10-16T14:11:11Z

@nordicjm and @gmarull please re-review.

subsys/net/lib/nrf70_fw_ext/Kconfig

subsys/net/lib/nrf70_fw_ext/rpu_fw_patches.ld

.

This is used by Matter samples to save internal flash memory. Signed-off-by: Chaitanya Tata <[email protected]>

This module implements the necessary handling for store and use nRF70 firmware patches from the external flash, as this uses NCS tooling, this is carved out from nRF70 driver as a separate module. Implements SHEL-2988 partially. Signed-off-by: Chaitanya Tata <[email protected]>

The firmware bins now are part of hal_nordic fetched using west blobs. Signed-off-by: Chaitanya Tata <[email protected]>

This reverts commit 0c27447 partially i.e., except for Zigbee weather station, rest of Matter samples are reinstated as now Matter over Wi-Fi is working. Signed-off-by: Chaitanya Tata <[email protected]>

This option depends on MbedTLS SHA256 configuration in Zephyr, but that option cannot be enabled with nRF security and there is no easy way to resolve this dependency. Disable this option by default for now. Signed-off-by: Chaitanya Tata <[email protected]>

We need to use Link Time Optimization to fit the code into the FLASH memory space. Signed-off-by: Arkadiusz Balys <[email protected]>

krish2718 requested review from ArekBalysNordic, nordicjm, rado17 and sachinthegreen October 5, 2024 14:58

krish2718 requested review from a team as code owners October 5, 2024 14:58

krish2718 added this to the 2.8.0 milestone Oct 5, 2024

github-actions bot added manifest changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Oct 5, 2024

NordicBuilder added manifest-zephyr DNM labels Oct 5, 2024

nordicjm requested changes Oct 7, 2024

View reviewed changes

krish2718 force-pushed the add_ext_flash_support branch from b210e5d to 3af4f88 Compare October 7, 2024 08:16

sachinthegreen approved these changes Oct 7, 2024

View reviewed changes

krish2718 force-pushed the add_ext_flash_support branch 3 times, most recently from 0fb558b to 51c3950 Compare October 8, 2024 17:37

krish2718 requested a review from a team as a code owner October 8, 2024 17:37

NordicBuilder added the manifest-matter label Oct 8, 2024

rado17 reviewed Oct 9, 2024

View reviewed changes

subsys/net/lib/nrf70_fw_ext/ext_fw_load.c Outdated Show resolved Hide resolved

rado17 approved these changes Oct 9, 2024

View reviewed changes

gmarull previously requested changes Oct 9, 2024

View reviewed changes

subsys/net/lib/nrf70_fw_ext/ext_fw_load.c Outdated Show resolved Hide resolved

krish2718 force-pushed the add_ext_flash_support branch from 51c3950 to c2c72e4 Compare October 9, 2024 18:47

ArekBalysNordic requested a review from a team as a code owner October 10, 2024 13:30

maciejbaczmanski reviewed Oct 10, 2024

View reviewed changes

samples/matter/lock/boards/nrf7002dk_nrf5340_cpuapp.conf Outdated Show resolved Hide resolved

ArekBalysNordic force-pushed the add_ext_flash_support branch from e2accd5 to bae829a Compare October 10, 2024 13:32

krish2718 requested review from gmarull, nordicjm and rado17 October 11, 2024 14:03

krish2718 force-pushed the add_ext_flash_support branch 3 times, most recently from 3631094 to f3fa12a Compare October 11, 2024 19:05

shanthanordic requested a review from krga2022 October 14, 2024 06:35

nordicjm requested changes Oct 14, 2024

View reviewed changes

subsys/net/lib/nrf70_fw_ext/CMakeLists.txt Outdated Show resolved Hide resolved

subsys/net/lib/nrf70_fw_ext/ext_fw_load.c Outdated Show resolved Hide resolved

cmake/sysbuild/nrf700x.cmake Outdated Show resolved Hide resolved

rlubos approved these changes Oct 16, 2024

View reviewed changes

krish2718 force-pushed the add_ext_flash_support branch from f3fa12a to af580c4 Compare October 16, 2024 14:10

krish2718 requested a review from nordicjm October 16, 2024 14:10

ArekBalysNordic approved these changes Oct 16, 2024

View reviewed changes

krish2718 force-pushed the add_ext_flash_support branch from af580c4 to 781274e Compare October 16, 2024 20:17

nordicjm approved these changes Oct 17, 2024

View reviewed changes

subsys/net/lib/nrf70_fw_ext/Kconfig Outdated Show resolved Hide resolved

subsys/net/lib/nrf70_fw_ext/rpu_fw_patches.ld Outdated Show resolved Hide resolved

krish2718 force-pushed the add_ext_flash_support branch from 781274e to db1db9e Compare October 18, 2024 14:31

NordicBuilder removed the DNM label Oct 18, 2024

krish2718 force-pushed the add_ext_flash_support branch from db1db9e to 171385a Compare October 18, 2024 14:49

krish2718 and others added 6 commits October 19, 2024 16:12

manifest: sdk-zephyr: Pull ext flash support for nRF70 FW patches

e5f5868

This is used by Matter samples to save internal flash memory. Signed-off-by: Chaitanya Tata <[email protected]>

sysbuild: Fix nRF70 Firmware bins path

f4cfbb7

The firmware bins now are part of hal_nordic fetched using west blobs. Signed-off-by: Chaitanya Tata <[email protected]>

Revert "scripts: quarantine: quarantine Matter samples"

17ca99c

This reverts commit 0c27447 partially i.e., except for Zigbee weather station, rest of Matter samples are reinstated as now Matter over Wi-Fi is working. Signed-off-by: Chaitanya Tata <[email protected]>

samples: matter: Enable LTO for all nRF7002 DK variants.

39cfa1e

We need to use Link Time Optimization to fit the code into the FLASH memory space. Signed-off-by: Arkadiusz Balys <[email protected]>

krish2718 force-pushed the add_ext_flash_support branch from 171385a to 39cfa1e Compare October 19, 2024 10:42

carlescufi merged commit 6b61fc8 into nrfconnect:main Oct 19, 2024
13 checks passed

Uh oh!

wifi: Add ext flash support for firmware patches #17652

wifi: Add ext flash support for firmware patches #17652

Uh oh!

Conversation

krish2718 commented Oct 5, 2024

Uh oh!

NordicBuilder commented Oct 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

NordicBuilder commented Oct 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CI Information

Inputs:

Sources:

Github labels

Outputs:

Toolchain

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

Uh oh!

NordicBuilder commented Oct 5, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

krish2718 commented Oct 10, 2024

Uh oh!

krish2718 commented Oct 10, 2024

Uh oh!

rlubos commented Oct 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

krish2718 commented Oct 16, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

NordicBuilder commented Oct 5, 2024 •

edited

Loading

NordicBuilder commented Oct 5, 2024 •

edited

Loading

rlubos commented Oct 11, 2024 •

edited

Loading